GNOME Bugzilla – Bug 730765
Compile warning cleanups
Last modified: 2014-05-26 16:11:11 UTC
There are still a few warnings left about deprecated gtk+ API use in gsd-ldsm-dialog.c . Can we get rid of that file alltogether? It seems to only be used when the notification server doesn't implement interactive notifications which isn't really a problem for GNOME.
Created attachment 277200 [details] [review] media-keys: Extract the MediaKeyType enum into its own header This allows us to not include shortcuts-list.h in other files and thus avoids the media_keys array being defined in more than one place.
Created attachment 277201 [details] [review] xsettings: Remove support for multiple X screens Support for this has been removed from mutter and gtk+ so there's no point in having it here.
Created attachment 277202 [details] [review] xrandr: Remove unused function
Created attachment 277203 [details] [review] locate-pointer: Remove support for multiple X screens Support for this has been removed from mutter and gtk+ so there's no point in having it here.
Created attachment 277204 [details] [review] locate-pointer: Replace deprecated gdk_window_get_pointer
Created attachment 277205 [details] [review] Stop using deprecated GSettings API
Review of attachment 277200 [details] [review]: Sure
Review of attachment 277201 [details] [review]: Looks good.
Review of attachment 277202 [details] [review]: Sure.
Review of attachment 277203 [details] [review]: Looks good. Can you make a separate patch to rename the left-over "j" variable as well?
Review of attachment 277204 [details] [review]: ++
Review of attachment 277205 [details] [review]: Please split those up. Given the amount of code needed, this would be nicer to have in GLib.
(In reply to comment #10) > Looks good. Can you make a separate patch to rename the left-over "j" variable > as well? I don't think there's a left-over j variable. Note that the code was actually re-defining j inside if (has_entries) {}
I've split the last one in 3. Attachment 277200 [details] pushed as f6df846 - media-keys: Extract the MediaKeyType enum into its own header Attachment 277201 [details] pushed as f160836 - xsettings: Remove support for multiple X screens Attachment 277202 [details] pushed as 2d17960 - xrandr: Remove unused function Attachment 277203 [details] pushed as cf677a9 - locate-pointer: Remove support for multiple X screens Attachment 277204 [details] pushed as 41a023e - locate-pointer: Replace deprecated gdk_window_get_pointer