After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730765 - Compile warning cleanups
Compile warning cleanups
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2014-05-26 14:35 UTC by Rui Matos
Modified: 2014-05-26 16:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
media-keys: Extract the MediaKeyType enum into its own header (6.47 KB, patch)
2014-05-26 14:35 UTC, Rui Matos
committed Details | Review
xsettings: Remove support for multiple X screens (14.40 KB, patch)
2014-05-26 14:35 UTC, Rui Matos
committed Details | Review
xrandr: Remove unused function (1.66 KB, patch)
2014-05-26 14:35 UTC, Rui Matos
committed Details | Review
locate-pointer: Remove support for multiple X screens (4.84 KB, patch)
2014-05-26 14:35 UTC, Rui Matos
committed Details | Review
locate-pointer: Replace deprecated gdk_window_get_pointer (2.25 KB, patch)
2014-05-26 14:35 UTC, Rui Matos
committed Details | Review
Stop using deprecated GSettings API (4.69 KB, patch)
2014-05-26 14:35 UTC, Rui Matos
committed Details | Review

Description Rui Matos 2014-05-26 14:35:06 UTC
There are still a few warnings left about deprecated gtk+ API use in
gsd-ldsm-dialog.c . Can we get rid of that file alltogether? It seems
to only be used when the notification server doesn't implement
interactive notifications which isn't really a problem for GNOME.
Comment 1 Rui Matos 2014-05-26 14:35:09 UTC
Created attachment 277200 [details] [review]
media-keys: Extract the MediaKeyType enum into its own header

This allows us to not include shortcuts-list.h in other files and thus
avoids the media_keys array being defined in more than one place.
Comment 2 Rui Matos 2014-05-26 14:35:13 UTC
Created attachment 277201 [details] [review]
xsettings: Remove support for multiple X screens

Support for this has been removed from mutter and gtk+ so there's no
point in having it here.
Comment 3 Rui Matos 2014-05-26 14:35:21 UTC
Created attachment 277202 [details] [review]
xrandr: Remove unused function
Comment 4 Rui Matos 2014-05-26 14:35:26 UTC
Created attachment 277203 [details] [review]
locate-pointer: Remove support for multiple X screens

Support for this has been removed from mutter and gtk+ so there's no
point in having it here.
Comment 5 Rui Matos 2014-05-26 14:35:32 UTC
Created attachment 277204 [details] [review]
locate-pointer: Replace deprecated gdk_window_get_pointer
Comment 6 Rui Matos 2014-05-26 14:35:35 UTC
Created attachment 277205 [details] [review]
Stop using deprecated GSettings API
Comment 7 Bastien Nocera 2014-05-26 14:59:44 UTC
Review of attachment 277200 [details] [review]:

Sure
Comment 8 Bastien Nocera 2014-05-26 15:00:29 UTC
Review of attachment 277201 [details] [review]:

Looks good.
Comment 9 Bastien Nocera 2014-05-26 15:01:16 UTC
Review of attachment 277202 [details] [review]:

Sure.
Comment 10 Bastien Nocera 2014-05-26 15:02:13 UTC
Review of attachment 277203 [details] [review]:

Looks good. Can you make a separate patch to rename the left-over "j" variable as well?
Comment 11 Bastien Nocera 2014-05-26 15:03:12 UTC
Review of attachment 277204 [details] [review]:

++
Comment 12 Bastien Nocera 2014-05-26 15:04:50 UTC
Review of attachment 277205 [details] [review]:

Please split those up. Given the amount of code needed, this would be nicer to have in GLib.
Comment 13 Rui Matos 2014-05-26 15:42:06 UTC
(In reply to comment #10)
> Looks good. Can you make a separate patch to rename the left-over "j" variable
> as well?

I don't think there's a left-over j variable. Note that the code was actually re-defining j inside if (has_entries) {}
Comment 14 Rui Matos 2014-05-26 16:10:46 UTC
I've split the last one in 3.

Attachment 277200 [details] pushed as f6df846 - media-keys: Extract the MediaKeyType enum into its own header
Attachment 277201 [details] pushed as f160836 - xsettings: Remove support for multiple X screens
Attachment 277202 [details] pushed as 2d17960 - xrandr: Remove unused function
Attachment 277203 [details] pushed as cf677a9 - locate-pointer: Remove support for multiple X screens
Attachment 277204 [details] pushed as 41a023e - locate-pointer: Replace deprecated gdk_window_get_pointer