After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730753 - popupMenu: Hide separator label when not in use
popupMenu: Hide separator label when not in use
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-05-26 09:36 UTC by Florian Müllner
Modified: 2014-05-27 17:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
popupMenu: Hide separator label when not in use (1.28 KB, patch)
2014-05-26 09:36 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-05-26 09:36:36 UTC 
See patch. Spotted while working on bug 730752.
Comment 1 Florian Müllner 2014-05-26 09:36:40 UTC 
Created attachment 277187 [details] [review]
popupMenu: Hide separator label when not in use

The optional label support introduced in commit af063dc2f2ec broke
the centering of separators, as the label still adds additional
spacing even when empty.
Properly hide the label actor in that case to fix the alignment.
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-05-26 12:16:03 UTC 
Review of attachment 277187 [details] [review]:

OK.
Comment 3 Florian Müllner 2014-05-27 17:52:09 UTC 
Attachment 277187 [details] pushed as 38d8e46 - popupMenu: Hide separator label when not in use