GNOME Bugzilla – Bug 730613
Drop last uses of GtkMisc
Last modified: 2017-01-15 03:44:17 UTC
Created attachment 277021 [details] [review] [PATCH 2/9] GtkLabel: Drop use of GtkMisc::x/yalign The following patches make us stop using GtkMisc altogether.
Created attachment 277022 [details] [review] [PATCH 3/9] GtkImage: Drop use of GtkMisc::x/yalign
Created attachment 277023 [details] [review] [PATCH 4/9] GtkAccelLabel: Drop use of GtkMisc
Created attachment 277024 [details] [review] [PATCH 5/9] GtkAssistant: Drop use of GtkMisc
Created attachment 277025 [details] [review] [PATCH 6/9] GtkToolButton: Drop use of GtkMisc
Created attachment 277026 [details] [review] [PATCH 7/9] GtkLabel: Stop deriving from GtkMisc
Created attachment 277027 [details] [review] [PATCH 8/9] GtkImage: Stop deriving from GtkMisc
Created attachment 277028 [details] [review] [PATCH 9/9] GtkButton: No more special treatment for GtkMisc
Created attachment 277040 [details] [review] GtkMisc: Keep gtk_misc_set_alignment working Patches 7 and 8 should be deferred until 4.0 when GtkMisc actually disappears. Until then, here is a patch to keep gtk_misc_set_alignment somewhat working until then.
Review of attachment 277021 [details] [review]: .
Review of attachment 277027 [details] [review]: There's also the following documentation that should be removed: * When handling events on the event box, keep in mind that coordinates * in the image may be different from event box coordinates due to * the alignment and padding settings on the image (see #GtkMisc). * The simplest way to solve this is to set the alignment to 0.0 * (left/top), and set the padding to zero. Then the origin of * the image will be the same as the origin of the event box.
IMHO It's a bit dirty to copy/paste eg: halign_to_float(), valign_to_float() in every widget. Couldn't those be common internal helpers?
all done now, afaics