After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730611 - Use margin-{start,end} instead of margin-{left,right}
Use margin-{start,end} instead of margin-{left,right}
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: ux
master
Other Linux
: Normal normal
: 0.12.0
Assigned To: Geary Maintainers
Geary Maintainers
gtk-3.12, review
: 746001 (view as bug list)
Depends on: 764812
Blocks:
 
 
Reported: 2014-05-23 00:48 UTC by Yosef Or Boczko
Modified: 2016-05-21 02:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use margin-{start,end} instead of margin-{left,right}: Close bgo #730611 (13.96 KB, patch)
2014-05-23 00:51 UTC, Yosef Or Boczko 		none Details | Review

Description Yosef Or Boczko 2014-05-23 00:48:11 UTC 
It fixes some wrong margin in RTL.

(It request GTK+ 3.12. so it will wait some time on bugzilla.)
Comment 1 Yosef Or Boczko 2014-05-23 00:51:37 UTC 
Created attachment 277019 [details] [review]
Use margin-{start,end} instead of margin-{left,right}: Close bgo #730611
Comment 2 Jim Nelson 2014-05-27 22:24:38 UTC 
I'm not sure I understand, Yosef -- are you saying this patch requires GTK+ 3.12?
Comment 3 Yosef Or Boczko 2014-05-28 21:32:37 UTC 
Yes, this patch requires GTK+ 3.12.
Since we depens on GTK+ 3.10 only, the margin in RTL is wrong in some
places, and we can to solve this by move the set of the margin to the code
and to set left_margin or right_margn depend on the direction.

Another solution is to move the margin to CSS, and use the dir support.
Comment 4 Robert Schroll 2015-03-11 01:42:55 UTC 
*** Bug 746001 has been marked as a duplicate of this bug. ***
Comment 5 Yosef Or Boczko 2015-03-11 01:47:07 UTC 
Hmm, I thought it pushed already.
We not yet depends on GTK+ 3.12? 3.16 it almost out...
Comment 6 Michael Gratton 2016-04-03 15:25:42 UTC 
I'll happy to bump the minimum GTK requirement to 3.12 once Ubuntu Xenial LTS has been released. This patch (does it need refreshing?) can be landed after that.
Comment 7 Michael Gratton 2016-05-21 02:53:02 UTC 
Updated patch committed to master as 0da3cb9. Ta!