GNOME Bugzilla – Bug 730496
tags: add mapping for ID3 "TPE3" frame
Last modified: 2016-05-15 15:34:54 UTC
Created attachment 276917 [details] [review] Mapping TPE3 to gst tag TPE3 (conductor/performer refinement) is not mapped to gst tag. TPE3 cab be mapped to GST_TAG_PERFORMER, which is registered during tag initialization. This eliminates "FIXME" message for TPE3 frames. Fix attached (gst-plugins-base/gst-libs/gst/tag/gstid3tag.c).
Review of attachment 276917 [details] [review]: Do you have one or more samples containing TPE* id3 tags? What would be the values in them? Might help understanding what id3 mean with those tags as they seem a bit ambiguous/overlapping. ::: gst-libs/gst/tag/gstid3tag.c @@ +114,3 @@ {GST_TAG_INTERPRETED_BY, "TPE4"}, {GST_TAG_MUSICAL_KEY, "TKEY"}, + {GST_TAG_PERFORMER, "TPE3"}, I'd like a second opinion here, currently we have TPE1 -> GST_TAG_ARTIST TPE2 -> GST_TAG_ALBUM_ARTIST (not exactly accurate) TPE3 -> ??? TPE4 -> GST_TAG_INTERPRETED_BY Performer and artist seem to be kind of overlapping, and TPE3 can also mean conductor... Maybe investigating some samples will make this more clear. The id3 docs (http://id3.org/id3v2.4.0-frames) says: 4.2.2 TPE1 Lead performer(s)/Soloist(s) 4.2.2 TPE2 Band/orchestra/accompaniment 4.2.2 TPE3 Conductor/performer refinement 4.2.2 TPE4 Interpreted, remixed, or otherwise modified by 4.2.2. Involved persons frames TPE1 The 'Lead artist/Lead performer/Soloist/Performing group' is used for the main artist. TPE2 The 'Band/Orchestra/Accompaniment' frame is used for additional information about the performers in the recording. TPE3 The 'Conductor' frame is used for the name of the conductor. TPE4 The 'Interpreted, remixed, or otherwise modified by' frame contains more information about the people behind a remix and similar interpretations of another existing piece.
matroska maps it like this. Here is the excerpt from matroska-read-common.c : GST_MATROSKA_TAG_ID_CONDUCTOR, GST_TAG_PERFORMER}, { /* Conductor/performer refinement. This is akin to the TPE3 tag in ID3. */
It would be great if some one could take a look at this. If not relevant, we can close this.
Someone will look at it when they get around to it, it's not the most urgent issue :)
Agree. I thought of clearing it up as pending for long. Thanks :)
This hung around so long that someone else pushed a mapping for TPE3. Thank you for your patch nevertheless! *** This bug has been marked as a duplicate of bug 762451 ***