After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730408 - Renable compiler warnings and fix a few that show up
Renable compiler warnings and fix a few that show up
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-05-19 23:10 UTC by Owen Taylor
Modified: 2014-05-20 00:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Renable compiler warnings and fix a few that show up (2.80 KB, patch)
2014-05-19 23:10 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2014-05-19 23:10:05 UTC 
The switch to GNOME_COMPILE_WARNINGS() caused -Wall and other
warnings to not actually be used since GNOME_COMPILE_WARNINGS()
just sets WARN_CFLAGS. Add WARN_CFLAGS to AM_CFLAGS so that
it takes effect.

Add  -Wno-error=deprecated-declarations so that when -Werror is
enabled, we don't fail on all the deprecated cogl and clutter
symbols.
Comment 1 Owen Taylor 2014-05-19 23:10:09 UTC 
Created attachment 276808 [details] [review]
Renable compiler warnings and fix a few that show up
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-05-19 23:14:42 UTC 
Review of attachment 276808 [details] [review]:

::: src/st/st-box-layout-child.c
@@ +94,3 @@
           break;
         case CLUTTER_BOX_ALIGNMENT_END:
           align = ST_ALIGN_END;

Missing a break here?

::: src/st/st-texture-cache.c
@@ +22,3 @@
 #include "config.h"
 
+#define COGL_ENABLE_EXPERIMENTAL_API /* for cogl_framebuffer_allocate */

I thought we enabled this globally? Or is that just for mutter?
Comment 3 Owen Taylor 2014-05-20 00:50:03 UTC 
Review of attachment 276808 [details] [review]:

::: src/st/st-box-layout-child.c
@@ +94,3 @@
           break;
         case CLUTTER_BOX_ALIGNMENT_END:
           align = ST_ALIGN_END;

Ouch, good catch.

::: src/st/st-texture-cache.c
@@ +22,3 @@
 #include "config.h"
 
+#define COGL_ENABLE_EXPERIMENTAL_API /* for cogl_framebuffer_allocate */

Just for Mutter.
Comment 4 Owen Taylor 2014-05-20 00:51:58 UTC 
Pushed with the missign break added.

Attachment 276808 [details] pushed as ff07d3a - Renable compiler warnings and fix a few that show up