Bug 730384 – Crash when None item is passed to notification.py:_update_track

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 730384 - Crash when None item is passed to notification.py:_update_track


Summary:	Crash when None item is passed to notification.py:_update_track

Description Vadim Rutkovsky 2014-05-19 15:40:44 UTC

From downstream bugreport https://bugzilla.redhat.com/show_bug.cgi?id=1099161

Traceback (most recent call last):

File "/usr/lib/python3.3/site-packages/gi/overrides/GLib.py", line 633 in <lambda>
```
return (lambda data: callback(*data), user_data)
```
File "/usr/lib/python3.3/site-packages/gnomemusic/notification.py", line 66 in _update_playing
```
self._update_track(self._player)
```
File "/usr/lib/python3.3/site-packages/gnomemusic/notification.py", line 75 in _update_track
```
artist = item.get_string(Grl.METADATA_KEY_ARTIST)\
```

AttributeError: 'NoneType' object has no attribute 'get_string'


Reproduced in gnome-music-3.10.4-1.fc20

Checked the code at seems it is being handled in 3.12 and master

Comment 1 Vadim Rutkovsky 2014-05-19 15:42:44 UTC

Fixed in https://git.gnome.org/browse/gnome-music/commit/?id=42ec17a