After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730305 - Build fails without IBus
Build fails without IBus
Status: RESOLVED FIXED
Product: gnome-initial-setup
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-05-17 17:00 UTC by Marcus Karlsson
Modified: 2014-09-16 14:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix the build when IBus is not used (2.18 KB, patch)
2014-05-17 17:00 UTC, Marcus Karlsson
accepted-commit_now Details | Review
Fix building without IBus (1.87 KB, patch)
2014-09-02 19:39 UTC, Marcus Karlsson
committed Details | Review

Description Marcus Karlsson 2014-05-17 17:00:49 UTC
Created attachment 276704 [details] [review]
Fix the build when IBus is not used

I attempted to build gnome-initial-setup without support for IBus and found a number of related compile-time errors in cc-input-chooser.c. I'm attaching a patch which should fix these issues.
Comment 1 Jasper St. Pierre (not reading bugmail) 2014-05-17 17:05:42 UTC
Review of attachment 276704 [details] [review]:

Looks good.
Comment 2 Matthias Clasen 2014-09-02 03:25:52 UTC
patch doesn't apply anymore, could you redo it please ?
Comment 3 Marcus Karlsson 2014-09-02 19:39:14 UTC
Created attachment 285171 [details] [review]
Fix building without IBus

Sure. Here's an up to date version of the patch.
Comment 4 Rui Matos 2014-09-16 14:08:48 UTC
Thanks for the patch

Attachment 285171 [details] pushed as 28f38bf - Fix building without IBus