After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730239 - e.g. used in strings where it should be i.e.
e.g. used in strings where it should be i.e.
Status: RESOLVED FIXED
Product: gimp-gap
Classification: Other
Component: general
Current SVN
Other All
: Normal normal
: ---
Assigned To: hof
hof
Depends on:
Blocks:
 
 
Reported: 2014-05-16 11:26 UTC by Anders Jonsson
Modified: 2015-07-24 07:13 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Anders Jonsson 2014-05-16 11:26:43 UTC
Hi,

in some strings in gimp-gap the abbreviation "e.g" (exempli gratia), meaning "for example", is used. 

In at least some of those, it seems obvious that it is "i.e." (id est), meaning "that is", that is the intended meaning.


I have listed the most obvious examples I have found below: 


gap/gap_morph_tween_dialog.c-
"Edges are detected on pixels where color or opacity differs significant "
"from the neighbor pixel."
"(e.g. more than the specified edge detection threshold)."),


gap/gap_mov_render.c:
/* resulting width at unscaled size (e.g. 100%) */

/* resulting height at unscaled size (e.g. 100%) */


gap/gap_colormask_exec.c:
/* delete (e.g. close) the previous frame image (form memory not from disk)


gap/gap_story_dialog.c:
/* handle video track sensitivity (not sensitive if stb is not present e.g. is NULL)  */

/* handle video track sensitivity (not sensitive if stb is not present e.g. is NULL)  */

/* in case player was not yet called (e.g this ist the very 1st player call)



There are other places where the use of e.g. is suspicious, but can't say anything for certain there.
Comment 1 hof 2014-05-22 05:46:20 UTC
I checked for wrong usage of the abbreviation "e.g." in translateable texts
and many comments, the resulting fixes were applied in the 
gap-2-8 branch of the git repository.

commit:	0a935e05674234f05a8ec07440442b4dfba4372f  2014-05-21 18:20:32 (GMT)

(a merge of the gap-2-8 branch to master will follow later ...)
Comment 2 Anders Jonsson 2014-06-30 09:35:47 UTC
(In reply to comment #1)
> I checked for wrong usage of the abbreviation "e.g." in translateable texts
> and many comments, the resulting fixes were applied in the 
> gap-2-8 branch of the git repository.

Thank you for your thorough work. The translatable strings look much better now.


There is however one translatable string with three more occurrences I would appreciate if you could take a look at. It is spelled "eg." without a dot in the middle there so it might have slipped under your radar because of that:

/gap/gap_fg_matting_dialog.c:442:

_("Select the tri_map layer (or layermask). "
" the tri-map shall be of same size as the input layer and "
" provides a rough user selection "
" where WHITE pixels in the tri map defines FOREGROUND (eg. opaque result) "
" BLACK pixels define BACKGROUND (eg. transparent result)"
" GRAY pixels (value 1 upto 240) are marked as Undefined "
" (eg. opacity to be processed by this filter.) )")


(My apologies if that one is intentional)


Regards,
Anders
Comment 3 Anders Jonsson 2015-07-24 07:13:44 UTC
The changes was merged to master in https://git.gnome.org/browse/gimp-gap/commit/?id=5a454b7f150260dde3e2822012aa156123c89fc3, so marking as fixed.