After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730236 - Make GtkInspector build and work On Windows
Make GtkInspector build and work On Windows
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.13.x
Other Windows
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-05-16 10:08 UTC by Fan, Chun-wei
Modified: 2014-05-16 15:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GtkInspector: Let it build on Windows (3.82 KB, patch)
2014-05-16 10:10 UTC, Fan, Chun-wei 		committed Details | Review

Description Fan, Chun-wei 2014-05-16 10:08:16 UTC 
Hi,

(Sorry if the selected component is not right for this bug).

As GTK+ now incorporates the use of parasite (GtkInspector), it needs to be updated in some areas so that it will build and run on Windows, including:

-Avoid including UNIX-only headers[*]
-Deduce data paths during run time for Windows (and Mac),
 like the rest of GTK+
-For Visual C++ builds, ensure that variables are declared
 at the top of the block.

[*]: Python support for GtkInspector is not done for Windows
     as it involves POSIX signal handling that needs to be
     ported for Windows before we can use it there, which
     will most likely belong to another bug.
Comment 1 Fan, Chun-wei 2014-05-16 10:10:26 UTC 
Created attachment 276659 [details] [review]
GtkInspector: Let it build on Windows

Hi,

This is my patch for this, and also use the Windows GTK+ theme by default on Windows.

With blessings, thank you!
Comment 2 Emmanuele Bassi (:ebassi) 2014-05-16 10:22:56 UTC 
Review of attachment 276659 [details] [review]:

looks good.
Comment 3 Fan, Chun-wei 2014-05-16 15:52:25 UTC 
Review of attachment 276659 [details] [review]:

Hello Emmanuele,

Thanks for the review-the patch has been pushed to master as 7ea0e275.

I will close this bug shortly.

With blessings.