After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730212 - rtspsrc: use a random ssrc for the internal session
rtspsrc: use a random ssrc for the internal session
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.3.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 729577 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-05-15 18:24 UTC by Aleix Conchillo Flaqué
Modified: 2014-05-16 14:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use random ssrc (1.46 KB, patch)
2014-05-15 18:27 UTC, Aleix Conchillo Flaqué 		committed Details | Review

Description Aleix Conchillo Flaqué 2014-05-15 18:24:58 UTC 
The internal SSRC is currently set to 0 instead of another random number as we do with MIKEY.

The following call overrides the internal suggested SSRC which is already a random number:

        g_object_set (rtpsession, "internal-ssrc", stream->send_ssrc, NULL);

However, stream->send_ssrc is only set in MIKEY key management.
Comment 1 Aleix Conchillo Flaqué 2014-05-15 18:27:44 UTC 
Created attachment 276617 [details] [review]
use random ssrc

Not sure if the change was intended. But this patch always uses a random SSRC whether we are in SRTP or not.
Comment 2 Olivier Crête 2014-05-15 22:34:48 UTC 
*** Bug 729577 has been marked as a duplicate of this bug. ***
Comment 3 Olivier Crête 2014-05-15 22:44:00 UTC 
That looks like a bug to me, as it was causing the issue reported in the duplicate bug, we probably want to merge your patch. Wim ?
Comment 4 Aleix Conchillo Flaqué 2014-05-15 22:51:27 UTC 
(In reply to comment #3)
> That looks like a bug to me, as it was causing the issue reported in the
> duplicate bug, we probably want to merge your patch. Wim ?

To me too. sender_ssrc didn't exist (thus never used) before so the internal session used the suggested random ssrc.
Comment 5 Wim Taymans 2014-05-16 14:59:20 UTC 
commit 782d65cab18afaa7227cad5202d6b3198913a9bb
Author: Aleix Conchillo Flaqué <aleix@oblong.com>
Date:   Thu May 15 11:25:50 2014 -0700

    rtspsrc: always use a random ssrc for the internal session
    
    Use a random SSRC different than 0 for the internal session SSRC.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=730212