After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730140 - box_drawing_generate.sh missing from tarball
box_drawing_generate.sh missing from tarball
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.36.x
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-14 17:43 UTC by Egmont Koblinger
Modified: 2014-05-14 18:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Egmont Koblinger 2014-05-14 17:43:57 UTC 
Tarballs include the generated box_drawing.h, but not the script that generates this.

As a result, the first "make" succeeeds, but after a "make clean" it doesn't work any more:

/bin/bash: ./box_drawing_generate.sh: No such file or directory
make[2]: *** [box_drawing.h] Error 127
make[2]: *** Deleting file `box_drawing.h'
Comment 1 Christian Persch 2014-05-14 17:51:04 UTC 
Fixed on master and 0-36.
Comment 2 Egmont Koblinger 2014-05-14 17:59:51 UTC 
Thx for the quick fix.

There are other generated files too (marshal.[ch], vteresources.c, vtetypebuiltins.[ch], plus box_drawing.h) that are included in the tarball, but removed on a "make clean".

And some files that can be generad, but are included in the tarball and not even removed on "make clean" (vteseq-list.h vteseq-2.c vteseq-n.c).

chpe, is this okay/intended this way?
Comment 3 Christian Persch 2014-05-14 18:41:35 UTC 
Fixed on master except for the gperf ones. IIRC Behdad did it like that because gperf is a somewhat more unusual build-time requirement; but I'd be fine with just requiring it and not disting the generated files.
Comment 4 Egmont Koblinger 2014-05-14 18:58:15 UTC 
Sounds fine, thanks!