After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730041 - autodiscover error finding <OABUrl> and <ASUrl>
autodiscover error finding <OABUrl> and <ASUrl>
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: Exchange
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-05-13 01:27 UTC by mastercactapus
Modified: 2014-05-30 13:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Example XML response (2.93 KB, text/plain)
2014-05-13 01:27 UTC, mastercactapus 		  Details
proposed patch (1.07 KB, patch)
2014-05-13 01:36 UTC, mastercactapus 		reviewed Details | Review
ewsclient: Autodiscover XML can contain multiple Protocol elements (1.19 KB, patch)
2014-05-30 13:44 UTC, Debarshi Ray 		committed Details | Review

Description mastercactapus 2014-05-13 01:27:06 UTC 
Created attachment 276421 [details]
Example XML response

GOA fails to check authentication reporting an error finding "ASUrl" for an exchange account. This happens when the first <Protocol> node does not contain <ASUrl> in the server response.
Comment 1 mastercactapus 2014-05-13 01:36:48 UTC 
Created attachment 276422 [details] [review]
proposed patch
Comment 2 Debarshi Ray 2014-05-30 13:28:52 UTC 
This is the counterpart of evolution-ews bug 730042
Comment 3 Debarshi Ray 2014-05-30 13:44:03 UTC 
Review of attachment 276422 [details] [review]:

Perfect. Thanks for the patch, Nathan. Extra points for fixing bug 730042 too.

::: src/goabackend/goaewsclient.c
@@ +298,3 @@
+          if (op_res) {
+            break;
+          }

Nit pick: We don't use braces for one line if branches.
Comment 4 Debarshi Ray 2014-05-30 13:44:55 UTC 
Created attachment 277548 [details] [review]
ewsclient: Autodiscover XML can contain multiple Protocol elements