GNOME Bugzilla – Bug 729999
fix rtl variants for symbolic icons
Last modified: 2014-05-14 00:19:07 UTC
I want to make GtkIconTheme deal automatically with rtl variants. For that to work, I need symbolic variants to be named foo-symbolic-rtl instead of foo-rtl-symbolic, as it is now. I also wonder why the rtl/ltr variants for symbolic icons don't quite match what we do for non-symbolic ones. I don't see any symlinks, and much fewer ltr names.
hold off on this for now, still working out the kinks in the gtk patch
The reason why you don't see symlinks for symbolic is that they are clones on the master svg sheet instead. Is there a benefit to doing symlinks?
no big advantage, the space savings are minimal since we're not including the image data for svgs in the cache. I've now pushed the patch that will make gtk look for -symbolic-rt instead of -rtl-symbolic to the wip/css-icons branch. I'll ping you when it lands on master, so we can get the icons renamed.
Created attachment 276450 [details] [review] provide rtl and ltr variants of pan icons - use symbolic links instead of SVG clones because of the suffix logic (-symbolic is at the end)
Looks good, except for the commit message seems to be confused: -rtl is at the end, not -symbolic. Also, don't forget to give all the other -rtl-symbolic icons the same treatment.
Attachment 276450 [details] pushed as 28d80bd - provide rtl and ltr variants of pan icons