After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729916 - libjuicer: Fix empty fallback titles with some CDs
libjuicer: Fix empty fallback titles with some CDs
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-10 13:08 UTC by Bastien Nocera
Modified: 2014-05-12 11:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libjuicer: Fix empty fallback titles with some CDs (3.57 KB, patch)
2014-05-10 13:08 UTC, Bastien Nocera 		reviewed Details | Review
libjuicer: Fix empty fallback titles with some CDs (3.30 KB, patch)
2014-05-11 13:32 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2014-05-10 13:08:28 UTC 
.
Comment 1 Bastien Nocera 2014-05-10 13:08:31 UTC 
Created attachment 276281 [details] [review]
libjuicer: Fix empty fallback titles with some CDs

My CD of "A Movie for Daddy" has some CD-Text information, but
simply empty ones. Tracks 4 and 10 have " " as track titles, which
we should ignore.

Rework the setting of metadata to ignore strings that are full of
spaces. This also fixes a small memory leak if the string contained
a '\0' instead of simply being NULL.
Comment 2 Phillip Wood 2014-05-11 11:09:42 UTC 
Review of attachment 276281 [details] [review]:

This looks good thanks apart from duplicating sj_str_is_empty()

::: libjuicer/sj-metadata-gvfs.c
@@ +75,3 @@
 
+static gboolean
+str_is_empty (const char *str)

This is a duplicate of sj_str_is_empty() in sj-util.c
Comment 3 Bastien Nocera 2014-05-11 13:32:23 UTC 
Created attachment 276330 [details] [review]
libjuicer: Fix empty fallback titles with some CDs

My CD of "A Movie for Daddy" has some CD-Text information, but
simply empty ones. Tracks 4 and 10 have " " as track titles, which
we should ignore.

Rework the setting of metadata to ignore strings that are full of
spaces. This also fixes a small memory leak if the string contained
a '\0' instead of simply being NULL.
Comment 4 Phillip Wood 2014-05-12 10:05:40 UTC 
Review of attachment 276330 [details] [review]:

Looks good, thanks
Comment 5 Bastien Nocera 2014-05-12 11:08:05 UTC 
Attachment 276330 [details] pushed as 765eeb2 - libjuicer: Fix empty fallback titles with some CDs