After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729768 - mpegtsbase: Raise limit to read more bytes initially to find PCR
mpegtsbase: Raise limit to read more bytes initially to find PCR
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.4.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-08 05:32 UTC by Sudip Jain
Modified: 2014-12-15 18:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Raise read limit on initial bytes to find PCR (884 bytes, patch)
2014-05-08 05:32 UTC, Sudip Jain
committed Details | Review

Description Sudip Jain 2014-05-08 05:32:19 UTC
Created attachment 276120 [details] [review]
Raise read limit on initial bytes to find PCR

The mpegtsbase reads 65536*10 bytes initially to find a PCR packet. In one of the streams (https://www.dropbox.com/s/4b70v8v8bxmv0uj/Samsung-Colorful-Variety-1080i.ts), the first PCR is located beyond 655360 bytes. Thus the pipeline terminates with a message "Internal stream error" 

The patched is attached doubling the limit of bytes(20*65536) for finding PCR . The stream works with the patch . I tested with more ".ts" streams to check the impact of the patch. Looks ok to me.  

This is a regression with respect to gstreamer v0.10. Kindly review the patch and fix the issue.
Comment 1 Tim-Philipp Müller 2014-05-08 11:11:10 UTC
Dropbox says "The file you're looking for has been deleted or removed."
Comment 2 Sudip Jain 2014-05-08 11:58:30 UTC
Oops, I moved it another folder. Check this one please

https://www.dropbox.com/s/87fylu13ze00b89/Samsung-Colorful-Variety-1080i.ts
Comment 3 Tim-Philipp Müller 2014-12-13 10:58:38 UTC
Thanks. Updated patch to apply to git master and pushed it to master:

commit 9f2cb50f54dac0c0953996a0068fa16c9f003b57
Author: Sudip Jain <sudip.jain@linaro.org>
Date:   Thu May 8 10:41:03 2014 +0530

    mpegtsbase: scan more bytes to find initial PCRs
    
    Fixes playback of Samsung-Colorful-Variety-1080i.ts.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=729768
Comment 4 Tim-Philipp Müller 2014-12-15 18:00:10 UTC
Cherry-picked into 1.4 branch.