After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729752 - Add missing (nullable) annotations on return values
Add missing (nullable) annotations on return values
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: ATK maintainer(s)
ATK maintainer(s)
Depends on:
Blocks: 729745
 
 
Reported: 2014-05-07 22:39 UTC by Evan Nemerson
Modified: 2014-05-08 16:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
introspection: add many missing Returns: (nullable) annotations (10.00 KB, patch)
2014-05-07 22:39 UTC, Evan Nemerson
committed Details | Review

Description Evan Nemerson 2014-05-07 22:39:34 UTC
Created attachment 276109 [details] [review]
introspection: add many missing Returns: (nullable) annotations

Now that bug #660879 has been fixed, I'm trying to go through and add the missing annotations.

I've never used ATK, so I'm not too familiar with the API, but I've gone through all of the Returns tags and, where there is text mentioning a potential NULL return value, I've added a (nullable) annotation.  I'm sure there are other functions which may return NULL but I doubt I have added annotations where they aren't appropriate, so this should be safe.
Comment 1 Alejandro Piñeiro Iglesias (IRC: infapi00) 2014-05-08 10:34:09 UTC
Review of attachment 276109 [details] [review]:

Looks good to me. Thanks.
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2014-05-08 10:41:58 UTC
(In reply to comment #1)
> Review of attachment 276109 [details] [review]:
> 
> Looks good to me. Thanks.

Just a comment: please include the bug number on the commit message when you push it. Thanks.