After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729598 - Populate page 2 of the Widget Factory
Populate page 2 of the Widget Factory
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-05-05 21:01 UTC by lamefun
Modified: 2014-05-11 15:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Populate page 2 of the Widget Factory (26.35 KB, patch)
2014-05-05 21:01 UTC, lamefun 		accepted-commit_now Details | Review
Screenshot (279.94 KB, image/png)
2014-05-05 21:02 UTC, lamefun 		  Details
Populate page 2 of the Widget Factory (26.73 KB, patch)
2014-05-06 06:55 UTC, lamefun 		committed Details | Review
Updated screenshot (189.38 KB, image/png)
2014-05-06 06:57 UTC, lamefun 		  Details

Description lamefun 2014-05-05 21:01:14 UTC 
Created attachment 275916 [details] [review]
Populate page 2 of the Widget Factory

patch
Comment 1 lamefun 2014-05-05 21:02:12 UTC 
Created attachment 275917 [details]
Screenshot
Comment 2 Matthias Clasen 2014-05-05 22:14:16 UTC 
Review of attachment 275916 [details] [review]:

that looks good to me, thanks
Comment 3 Matthias Clasen 2014-05-06 01:43:40 UTC 
One thing though - you should add a separator between the two calendar and the expander in the right column
Comment 4 lamefun 2014-05-06 06:55:41 UTC 
Created attachment 275937 [details] [review]
Populate page 2 of the Widget Factory

Updated patch
Comment 5 lamefun 2014-05-06 06:57:30 UTC 
Created attachment 275938 [details]
Updated screenshot
Comment 6 Matthias Clasen 2014-05-07 22:14:13 UTC 
Review of attachment 275937 [details] [review]:

ok, though it would be nice if the commit message described what was added and moved here:

Add a GtkCalendar, and move the expander over from page 1, where it didn't have enough room.
Comment 7 Matthias Clasen 2014-05-11 15:28:14 UTC 
Attachment 275937 [details] pushed as 9187b6b - Populate page 2 of the Widget Factory