After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729553 - qtdemux: tries to reply to a byte position query with a time position
qtdemux: tries to reply to a byte position query with a time position
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.2.4
Other All
: Normal normal
: 1.3.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-05 08:03 UTC by Eric
Modified: 2014-05-09 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch that should fix this issue (841 bytes, patch)
2014-05-05 08:03 UTC, Eric 		reviewed Details | Review
patch formated as aked (1.16 KB, patch)
2014-05-09 14:51 UTC, Eric 		committed Details | Review

Description Eric 2014-05-05 08:03:06 UTC 
Created attachment 275871 [details] [review]
Patch that should fix this issue 

Hi
The qtdemux tries to reply a byte position query with a time position. 
Resulting in a assert.
Comment 1 Tim-Philipp Müller 2014-05-05 15:47:18 UTC 
That looks fine, thanks for the patch.

Could you provide a patch in 'git format-patch' format by any chance? (Commit locally and then use 'git format-patch -1' to create a patch file). That way we don't have to type your author info and commit message.
Comment 2 Eric 2014-05-09 14:51:11 UTC 
Created attachment 276248 [details] [review]
patch formated as aked
Comment 3 Eric 2014-05-09 14:51:34 UTC 
(In reply to comment #1)
> That looks fine, thanks for the patch.
> 
> Could you provide a patch in 'git format-patch' format by any chance? (Commit
> locally and then use 'git format-patch -1' to create a patch file). That way we
> don't have to type your author info and commit message.

Here you are
Comment 4 Tim-Philipp Müller 2014-05-09 15:15:08 UTC 
Brilliant, thank you! Pushed to master:

 commit bd51aa7aa8a4e01b880ddf9c3174f122ad15e7d3
 Author: Eric Trousset <etrousset@awox.com>
 Date:   Fri May 9 16:48:58 2014 +0200

    qtdemux: don't respond to a position query in BYTE format with a TIME position
    
    https://bugzilla.gnome.org/show_bug.cgi?id=729553