After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729480 - Use the correct parent widget in the gedit-window.ui file
Use the correct parent widget in the gedit-window.ui file
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-03 21:11 UTC by Yosef Or Boczko
Modified: 2014-05-04 08:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gedit-window: Use the correct parent widget (870 bytes, patch)
2014-05-03 21:11 UTC, Yosef Or Boczko
committed Details | Review

Description Yosef Or Boczko 2014-05-03 21:11:08 UTC
It cause to crash with gtk+ from git master:
$ ./gedit/gedit 

(lt-gedit:6446): Gtk-CRITICAL **: Error building template class 'GeditWindow' for an instance of type 'GeditWindow': Template parent type `GtkWindow' does not match instance parent type `GtkApplicationWindow'.
sys:1: Warning: g_object_bind_property_full: assertion 'G_IS_OBJECT (source)' failed

(lt-gedit:6446): GLib-GIO-CRITICAL **: g_settings_bind_with_mapping: assertion 'G_IS_OBJECT (object)' failed
sys:1: Warning: invalid (NULL) pointer instance
sys:1: Warning: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed

(lt-gedit:6446): Gtk-CRITICAL **: gtk_menu_button_set_menu_model: assertion 'GTK_IS_MENU_BUTTON (menu_button)' failed

(lt-gedit:6446): Gtk-CRITICAL **: gtk_menu_button_set_menu_model: assertion 'GTK_IS_MENU_BUTTON (menu_button)' failed

(lt-gedit:6446): Gtk-CRITICAL **: gtk_statusbar_get_context_id: assertion 'GTK_IS_STATUSBAR (statusbar)' failed

(lt-gedit:6446): Gtk-CRITICAL **: gtk_statusbar_get_context_id: assertion 'GTK_IS_STATUSBAR (statusbar)' failed

(lt-gedit:6446): Gtk-CRITICAL **: gtk_statusbar_get_context_id: assertion 'GTK_IS_STATUSBAR (statusbar)' failed

(lt-gedit:6446): GLib-GIO-CRITICAL **: g_settings_bind_with_mapping: assertion 'G_IS_OBJECT (object)' failed

(lt-gedit:6446): Gtk-CRITICAL **: gtk_menu_button_set_menu_model: assertion 'GTK_IS_MENU_BUTTON (menu_button)' failed
Segmentation fault (core dumped)
Comment 1 Yosef Or Boczko 2014-05-03 21:11:44 UTC
Created attachment 275765 [details] [review]
gedit-window: Use the correct parent widget
Comment 2 sébastien lafargue 2014-05-03 21:37:41 UTC
Review of attachment 275765 [details] [review]:

hi, good catch, it works, push it.
Comment 3 Yosef Or Boczko 2014-05-03 21:38:32 UTC
Review of attachment 275765 [details] [review]:

Pushed as 27bacac - gedit-window: Use the correct parent widget
Comment 4 Paolo Borelli 2014-05-04 08:35:56 UTC
Please cherry-pick on the gnome-3-10 branch too
Comment 5 Yosef Or Boczko 2014-05-04 08:39:14 UTC
To push to the gnome-3-10 or gnome-3-12?