After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729406 - Deprecate GNOME_CXX_WARNINGS
Deprecate GNOME_CXX_WARNINGS
Status: RESOLVED FIXED
Product: gnome-common
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Gnome Common Maintainer(s)
Gnome Common Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-05-02 15:12 UTC by Philip Withnall
Modified: 2015-01-27 11:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
macros2: Deprecate GNOME_CXX_WARNINGS (1.45 KB, patch)
2015-01-27 10:19 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2014-05-02 15:12:12 UTC 
We think it should be possible to merge GNOME_CXX_WARNINGS into GNOME_COMPILE_WARNINGS by checking the currently set language in the AC_LANG_[PUSH|POP] stack.

GNOME_CXX_WARNINGS could then be deprecated.
Comment 1 David King 2014-05-02 15:50:16 UTC 
One way of doing the merge for GNOME_COMPILE_WARNINGS would be:

https://git.gnome.org/browse/mm-common/tree/macros/mm-warnings.m4#n74
Comment 2 David King 2014-05-10 18:55:33 UTC 
I made some progress on merging the CXX macros into the C ones:

https://git.gnome.org/browse/gnome-common/log/?h=wip/deprecate-cxx-macros

Remaining tasks include moving the strict ISO CXX warning option, deprecating the CXX macros with AU_DEFUN, adding the CXX-specific problems to the right place and finally a lot of testing.
Comment 3 David King 2015-01-26 15:16:56 UTC 
Let's just deprecate this without replacement, as it is not useful (only adds a couple of warning options) and few projects are using it.
Comment 4 Philip Withnall 2015-01-27 10:19:54 UTC 
Created attachment 295513 [details] [review]
macros2: Deprecate GNOME_CXX_WARNINGS

Just as for GNOME_COMPILE_WARNINGS, GNOME_CXX_WARNINGS has been
deprecated in favour of AX_COMPILER_FLAGS. See commit
b57bae0be3df241220b1fba3120e2f50261258e5 for details.
Comment 5 David King 2015-01-27 10:24:33 UTC 
Review of attachment 295513 [details] [review]:

Looks good to me.
Comment 6 Philip Withnall 2015-01-27 11:30:58 UTC 
Attachment 295513 [details] pushed as 2bffd7e - macros2: Deprecate GNOME_CXX_WARNINGS