After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729403 - Deprecate GNOME_DEBUG_CHECK
Deprecate GNOME_DEBUG_CHECK
Status: RESOLVED FIXED
Product: gnome-common
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Gnome Common Maintainer(s)
Gnome Common Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-05-02 14:55 UTC by Philip Withnall
Modified: 2014-11-20 23:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
macros2: Deprecate GNOME_DEBUG_CHECK (7.24 KB, patch)
2014-08-25 23:14 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2014-05-02 14:55:33 UTC 
As discussed with David at the developer hackfest, we should deprecate and remove GNOME_DEBUG_CHECK.
 • It’s really small.
 • It has the benefit that it forces a consistent --enable-debug argument across all modules.
 • It has the downside that the origin of the GNOME_ENABLE_DEBUG #define in code is not clear.

I suggest we move it to the autoconf-archive[1] and remove the GNOME-specific references from it. Modules should then be ported to use the new macro.

Alternatively, we could deprecate it and suggest modules just inline the code.

[1]: http://www.gnu.org/software/autoconf-archive/
Comment 1 Philip Withnall 2014-05-10 20:31:35 UTC 
Macro upstreamed at: http://savannah.gnu.org/patch/index.php?8452
Comment 2 Philip Withnall 2014-05-11 22:24:17 UTC 
There's some discussion in the upstream bug about possible feature extensions to the macro which look interesting.
Comment 3 Philip Withnall 2014-08-25 23:14:47 UTC 
Created attachment 284459 [details] [review]
macros2: Deprecate GNOME_DEBUG_CHECK

The autoconf-archive AX_DEBUG_CHECK macro should be used instead, or the
macro contents should just be substituted into configure.ac directly,
since it’s so simple.
Comment 4 David King 2014-08-26 07:36:13 UTC 
Review of attachment 284459 [details] [review]:

Looks good to me.
Comment 5 Philip Withnall 2014-08-28 17:46:14 UTC 
Attachment 284459 [details] pushed as f9073d5 - macros2: Deprecate GNOME_DEBUG_CHECK
Comment 6 Eric Gallager 2014-11-20 23:03:06 UTC 
This change caused gnome-common to try to install ax_check_enable_debug.m4 to the same place that the autoconf-archive package installs the macro file, which can cause the autoconf-archive and gnome-common packages to conflict in various package management systems (I've experienced the conflict with at least MacPorts and Homebrew so far; I would assume it exists for others as well though).
For confirmation, here is a downstream bug report of this conflict:
https://trac.macports.org/ticket/45427