Created attachment 275430 [details] [review]
media-keys: Remove unused "needs_term" argument

Created attachment 275431 [details] [review]
media-keys: Set the keyring env for other launchers too

Instead of only applying the keyring environment to custom shortcuts,
also apply it to other applications we launch.

Created attachment 275432 [details] [review]
media-keys: Simplify launching custom commands

Instead of launching the app ourselves, create a new GAppInfo from the
custom command's string.

Review of attachment 275430 [details] [review]:

ok

Review of attachment 275431 [details] [review]:

::: plugins/media-keys/gsd-media-keys-manager.c
@@ +231,3 @@
+	GVariantIter *iter;
+
+	variant = g_dbus_connection_call_sync (manager->priv->connection,

Can't we do this only once, asynchronously during startup ?

Review of attachment 275432 [details] [review]:

looks fine

(In reply to comment #5)
> Review of attachment 275431 [details] [review]:
> 
> ::: plugins/media-keys/gsd-media-keys-manager.c
> @@ +231,3 @@
> +    GVariantIter *iter;
> +
> +    variant = g_dbus_connection_call_sync (manager->priv->connection,
> 
> Can't we do this only once, asynchronously during startup ?

It's the same code that's currently in get_keyring_env(), so I'm going to leave it that way, and file a separate bug about it (bug 732687).

Attachment 275430 [details] pushed as 96e743b - media-keys: Remove unused "needs_term" argument
Attachment 275431 [details] pushed as e132a43 - media-keys: Set the keyring env for other launchers too
Attachment 275432 [details] pushed as 9f10057 - media-keys: Simplify launching custom commands