GNOME Bugzilla – Bug 729051
Add shortcut to access gnome-control-center
Last modified: 2014-06-13 11:11:47 UTC
Created attachment 275255 [details] [review] Add shortcut to start gnome-control-center My keyboard has a key meant to start the control-center. This patch adds support for this to gnome-settings daemon
Review of attachment 275255 [details] [review]: Nearly there. Can you make it hard-coded, like the other XF86... keys in there? I don't see a reason to make this configurable. (That would also mean that we can land this in GNOME 3.12, for your instant enjoyment :)
Created attachment 275312 [details] [review] Add shortcut to start gnome-control-center I had 2 reasons for making this configurable: - it's not much different from email (XF86Mail), calculator (XF86Calculator), file explorer (XF86Explorer) which are all configurable in the control center. Most of the hardcoded XF86xx keys seem hardware-oriented (trackpad, display, ..) rather than application-oriented - if the key is hardcoded as starting the control center, I was worried that it would not be possible to remap it to start something else in the 'custom launcher' section (iow a very good candidate key to map a launcher to would be wasted). After testing this patch, setting a shortcut to XF86Tools in the control center seems to just disable the key, which is not what I'm after :(
(In reply to comment #2) > Created an attachment (id=275312) [details] [review] > Add shortcut to start gnome-control-center > > I had 2 reasons for making this configurable: > > - it's not much different from email (XF86Mail), calculator (XF86Calculator), > file explorer (XF86Explorer) which are all configurable in the control center. > Most of the hardcoded XF86xx keys seem hardware-oriented (trackpad, display, > ..) rather than application-oriented Those are configurable for historical reasons, mostly. I guess that's fine to add then :/ > - if the key is hardcoded as starting the control center, I was worried that it > would not be possible to remap it to start something else in the 'custom > launcher' section (iow a very good candidate key to map a launcher to would be > wasted). After testing this patch, setting a shortcut to XF86Tools in the > control center seems to just disable the key, which is not what I'm after :( There's 2 bugs here. The control-center not knowing about hard-coded keys, and gnome-settings-daemon applying the settings in one go, instead of hard-coded first, then the others.
Review of attachment 275312 [details] [review]: This is good for 3.12. Commit the other one to master. ::: plugins/media-keys/gsd-media-keys-manager.c @@ +961,2 @@ app_info = g_desktop_app_info_new (desktop); + if ((app_info == NULL) && (alt_desktop != NULL)) No need for the extra parenthesis.
Pushed the last patch to the gnome-3-12 branch, though it's probably not very useful at this point. Pushed the initial patch to master.