After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729042 - Unable to build g-c because of libchess.vapi not being generated
Unable to build g-c because of libchess.vapi not being generated
Status: RESOLVED FIXED
Product: gnome-chess
Classification: Applications
Component: General
git master
Other FreeBSD
: Low major
: ---
Assigned To: Michael Catanzaro
gnome-chess-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-27 07:40 UTC by Gustau Pérez i Querol
Modified: 2014-05-18 00:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Distribute libchess.vapi (797 bytes, patch)
2014-05-18 00:51 UTC, Michael Catanzaro
committed Details | Review

Description Gustau Pérez i Querol 2014-04-27 07:40:02 UTC
It would appear that after commit 17f0005f342 (library split) we can't build gnome-chess. The libchess.vapi file isn't there (I can't see the generation of that file anywhere). 

This happens with gtk-3.12.1, glib-2.40.0 and gobject-introspection-1.40.0.

I'm attaching the build log. I'm unable to see where the libchess.vapi is being generated.
Comment 1 Michael Catanzaro 2014-04-28 05:21:26 UTC
Can you provide the build log please?  (It didn't get attached.) Thanks!
Comment 2 Michael Catanzaro 2014-04-28 05:34:48 UTC
Possibly the problem is if you are patching a file in src (to trigger the need for the vala compiler and the vapi) but not in lib (to trigger the generation of the vapi)?  Maybe the vapi should be distributed?
Comment 3 Gustau Pérez i Querol 2014-04-28 06:35:27 UTC
After reading your responses I reviewed 726614. I because the fix of 726614 got into 3.12.1 I forgot to stop removing chess-engine.c in our build infrastructure. 

After preventing the removal of chess-engine.c, the build went fine and 3.13.1 did build just fine. 

I'd close this bug. Also apologies for the noise.
Comment 4 Michael Catanzaro 2014-04-28 14:11:24 UTC
OK, so I was right! (A workaround if you had a patch you didn't want to remove would be to rm the stamp file in lib before building.)
 
I think it would be a good idea to distribute the vapi anyway, so that patching vala files outside libchess will "just work."
Comment 5 Michael Catanzaro 2014-05-18 00:51:54 UTC
The following fix has been pushed:
f2f2842 Distribute libchess.vapi
Comment 6 Michael Catanzaro 2014-05-18 00:51:57 UTC
Created attachment 276712 [details] [review]
Distribute libchess.vapi

This allows users to modify Vala files outside of lib/ without having to
manually remove anything.