After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728886 - GstGLColorConvert: some unused params in shaders
GstGLColorConvert: some unused params in shaders
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-24 15:38 UTC by Julien Isorce
Modified: 2014-05-23 06:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Julien Isorce 2014-04-24 15:38:01 UTC 
1: For example tex_scale1 / tex_scale2 are declared but not used in frag_REORDER : http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/gstglcolorconvert.c#n132

2: Also "i = info->in_n_textures" http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/gstglcolorconvert.c#n1049 looks suspicious as for example in videotestsrc ! RGB ! glimagesink it's equal to 1. So we should only handle the case where i is 0 in this case.

3: Third thing is the "width" param which is not defined for most of the shaders but we still try to set it: http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/gstglcolorconvert.c#n1061
Comment 1 Matthew Waters (ystreet00) 2014-04-27 13:15:00 UTC 
Both 1 and 3 are explicitly allowed by the GL spec so really do not matter.  If you care enough you can fix them :).

2. might need a -1 on the end of 'i = info->in_n_textures'.  Or I could have placed that there on purpose.
Comment 2 Matthew Waters (ystreet00) 2014-05-23 06:33:54 UTC 
Even with 2), it's in the same line as 3) which does not require fixing and is explicitly allowed by the spec.