GNOME Bugzilla – Bug 728820
Auto move windows broken with 3.12
Last modified: 2014-05-01 11:53:16 UTC
Hello, Since Gnome-Shell 3.12, the extension Auto Move Windows doesn't work anymore : it removes all the workspaces and doesn't allow me to create a new one (I am stuck with one workspace, even if I have some opened windows). It doesn't print any error in the looking-glass. I have tested on 2 computers on ArchLinux, one of these is running on a fresh install (installed directly with gnome 3.12, no upgrade from gnome 3.10). Thank you !
Please contact the extension auto directly. This is not the appropriate place to file bugs against such extensions.
(In reply to comment #1) > Please contact the extension auto directly. This is not the appropriate place > to file bugs against such extensions. No. The extension is part of the gnome-shell-extensions module, so this is indeed the appropriate place.
(In reply to comment #2) > (In reply to comment #1) > > Please contact the extension auto directly. This is not the appropriate place > > to file bugs against such extensions. > > No. The extension is part of the gnome-shell-extensions module, so this is > indeed the appropriate place. Oh indeed I though this was from e.g.o ... ignore my comment then.
Created attachment 275036 [details] [review] auto-move-windows: Fix fallout from API change MetaWindowActor.get_workspace() was removed, however the now used MetaWindow.get_workspace() returns a MetaWorkspace rather than an index, so can't be used directly. That should fix it.
Attachment 275036 [details] pushed as fee5495 - auto-move-windows: Fix fallout from API change Pushing, as the change is obviously correct (and was already reviewed when we fixed the core version of checkWorkspaces())
Many thanks, it works !
I found an other bug in the extension : for example, I have 4 workspaces with one window on each + 1 empty workspace added automatically. If I close the windows on the 3thrd workspace and then, from the overview, I close the window on the 4th workspace, it will close the workspace 3, 4 and 5 (so it will not keep the usual last empty workspace created dynamically). I have tried to fix it but I can't find a solution :(
(In reply to comment #7) > I found an other bug in the extension The extension is actually fine now, you found a bug in gnome-shell itself - patch coming :-)
Created attachment 275091 [details] [review] workspaceThumbnails: Fix removal of multiple workspaces When workspaces have been removed, we need to remove the corresponding thumbnails as well; the number of thumbnails that need removing is the difference between the old number of workspaces and the new one. Currently we assume that the old number of workspaces corresponds to the number of existing thumbnails, but that may actually be wrong: A thumbnail will still be animated out after its workspace has been removed. As a result, we end up removing too many thumbnails when a workspace is removed while a thumbnail of a previously removed workspace is still animating out. Fix this by basing the old number of workspaces only on thumbnails that have not been removed previously.
Review of attachment 275091 [details] [review]: OK.
Attachment 275091 [details] pushed as 05ddece - workspaceThumbnails: Fix removal of multiple workspaces
Sorry for the late answer, but it works well, thank you a lot for the quick answers and patches !