GNOME Bugzilla – Bug 728331
Multiple playlist with the same name is allowed
Last modified: 2018-01-10 14:40:05 UTC
If we use the name of an existing playlist to create a new playlist, the original playlist gets cleared because it is overwritten. We shouldn't allow creating a new playlist if the name already exists. According to Allan Day, we should just select the row for the original playlist if it already exists.
Created attachment 274446 [details] [review] widgets: Select playlist if already exists In Add to Playlist dialog, select the existing playlist if the name for the new playlist already exists.
Review of attachment 274446 [details] [review]: Looks good, but I'd prefer not to commit it before bug 728330 is resolved (as we operate on names here)
Creating a playlist no longer clears the old one, but we should still prevent creation of a new playlist with name already used since it is confusing.
Comment on attachment 274446 [details] [review] widgets: Select playlist if already exists New patch is in search-playlists branch in GitHub.
Created attachment 297069 [details] [review] prevent user from making duplicate playlists (i.e. playlists with the same name)
Bulk removing the 3.18 target.
*** Bug 769866 has been marked as a duplicate of this bug. ***
Apologies, this has been lying around for too long. This patch has however bitrotten, so it would be awesome if you could find the time to update it to current git. I don't think however a notification is what we want to let users know that a name is already taken. We might have to think of another solution there.
(In reply to Marinus Schraal from comment #8) > Apologies, this has been lying around for too long. This patch has however > bitrotten, so it would be awesome if you could find the time to update it to > current git. > > I don't think however a notification is what we want to let users know that > a name is already taken. We might have to think of another solution there. Hi, I am a newcomer and I want to work on this bug. Is anyone else working on it or is it open? And what other solution are you suggesting?
Created attachment 343284 [details] [review] Prevent adding playlist with same name - 1 When creating a repeated playlist, the dialog will highlight the existing playlist and simply disable the create playlist button. This is can be a good solution to this problem, the users will not allowed to create the playlist with same name, and then they will use the dialog-titlebar- button to add the tracks to the existing playlist. No need to create the notifications either.
Created attachment 343285 [details] [review] Prevent adding playlist with same name - 1
Created attachment 343286 [details] [review] Prevent adding playlist with same name - 2 When creating a repeated playlist, the dialog will highlight the existing playlist. If the add playlist button is pressed one more time, then the tracks will be added to existing playlist. This can work silently, the users will be shown the existing playlist, but for the ease of the users(they won't need to move to the button on above), they can press "Add"(the one on bottom which creates playlist) again to in fact add the tracks to the existing playlist. This is not necessarily an upgrade to my above patch.
Created attachment 344950 [details] [review] Prevent adding playlist with same name If creating a repeated playlist, the dialog will highlight the existing playlist and simply disable the create playlist button.
Review of attachment 344950 [details] [review]: The code is fine, thanks. I'm just not content with the interaction here: enter a name, you get to see the name in the list (selected) and the add button on top is highlighted. It is not obvious if this playlist has just been created or if it is something you are adding to. Maybe this entrybox should more act like a search while you type kind of thing. Also it should not be possible to create playlists with the names we already have reserved (the static & on-disk playlist). Maybe indicate them by a lock symbol and dimmed or something? The solution is incomplete I feel and we need some design input here. That being said, it could be a temporary solution. I'm still a bit on the fence about it.
Created attachment 345753 [details] [review] Fix referencing of the playlist variable In the code submitted by Abhinav Singh, the referencing of the playlist for creating a new playlist was wrong. Instead of self.playlist.create_playlist.... It would be self._playlist.create_playlist
Also I think the bug https://bugzilla.gnome.org/show_bug.cgi?id=778623 affects solving this bug.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-music/issues/19.