After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728261 - Use dark theme variant
Use dark theme variant
Status: RESOLVED FIXED
Product: gnome-mines
Classification: Applications
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-mines-maint
gnome-mines-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-15 13:06 UTC by Chris Johns (ter0)
Modified: 2014-04-24 00:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Prefer dark gtk theme (821 bytes, patch)
2014-04-15 13:06 UTC, Chris Johns (ter0) 		reviewed Details | Review
Prefer dark gtk theme (828 bytes, patch)
2014-04-16 07:57 UTC, Chris Johns (ter0) 		committed Details | Review

Description Chris Johns (ter0) 2014-04-15 13:06:03 UTC 
Created attachment 274364 [details] [review]
Prefer dark gtk theme

The mockups now use the dark theme variant. https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/games/mines/mines2-new.png
Comment 1 Michael Catanzaro 2014-04-15 19:28:30 UTC 
Review of attachment 274364 [details] [review]:

OK, but:

1) Nitpick: I'd prefer to do this in one line rather than two, simply to avoid introducing the extra local variable.
2) This is definitely required for the final design, but for the time being I don't think it is an improvement, since it clashes with the icons we currently use for the mines. I think I'd prefer to leave this bug open until we have those new icons ready.
Comment 2 Chris Johns (ter0) 2014-04-16 07:57:28 UTC 
Created attachment 274425 [details] [review]
Prefer dark gtk theme

no problem :)
Comment 3 Michael Catanzaro 2014-04-16 21:56:35 UTC 
Review of attachment 274425 [details] [review]:

Accepted, waiting for new icons before pushing. Thanks!
Comment 4 Michael Catanzaro 2014-04-23 13:53:59 UTC 
master looks kind of awful right now, so might as well get this out of the way. Thanks Chris!

Attachment 274425 [details] pushed as 606b6b3 - Prefer dark gtk theme
Comment 5 Michael Catanzaro 2014-04-24 00:54:45 UTC 
Hey Chris: Allan's been working on the new design in Bug #728483 and has actually reconsidered the change to the dark theme -- so don't be surprised if this gets reverted soon.  Sorry about that.