GNOME Bugzilla – Bug 728258
ios-universal: libvpx: Failure to build properly for armv7s
Last modified: 2014-04-16 12:48:58 UTC
libvpx doesn't build properly for armv7s. Requires adding armv7s support to the libvpx configure scripts.
I tried to fix this issue by modifying the recipe this way: * if the target is armv7s, replace arch with armv7 (and make it use the ios armv7 target) That wasn't enough since the compiler then complained about having two diferent "-arch" in the CFLAGS. * remove "-arch armv7s" from the CFLAGS, CPPFLAGS and LDFLAGS The problem is that while it builds everything ... we end up with two armv7 section in the universal library, and therefore the build fails. Something is definitely fishy in the way -arch is handled. I'm tempted to say the problem is in the patches we have for libvpx to make it support ios. We set -arch both in: * the generic cerbero system (in the CFLAGS, CPPFLAGS and LDFLAGS) * and also in the libvpx configuration system I'm tempted to say we should drop the -arch fiddling for ios in the libvpx configuration patches, and instead let is use the ones from the generic cerbero system.
Created attachment 274363 [details] [review] build: Add support for the armv7s architecture on Darwin builders Here’s a sample patch on libvpx master which should add support for armv7s so that universal binaries can be generated with both armv7 and armv7s sections. It’s completely untested (I don’t have time or access to a Darwin machine atm), but should be pretty much there.
commit 3e72fbad4c7f4856d9344080473b265f8fc5f3be Author: Edward Hervey <edward@collabora.com> Date: Wed Apr 16 14:22:54 2014 +0200 libvpx: Fix ios armv7s build Inspired by patch from Philip Withnall <philip.withnall@collabora.co.uk> https://bugzilla.gnome.org/show_bug.cgi?id=728258