After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728249 - iosavassetsrc: port to 1.0
iosavassetsrc: port to 1.0
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Mac OS
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 727885
Blocks:
 
 
Reported: 2014-04-15 09:50 UTC by Matthieu Bouron
Modified: 2014-04-24 10:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
applemedia: add new source/decoder element for iOS assets (35.27 KB, patch)
2014-04-15 09:53 UTC, Matthieu Bouron
none Details | Review
iosavassetsrc: Port to 1.0 (31.17 KB, patch)
2014-04-15 09:53 UTC, Matthieu Bouron
none Details | Review
iosavassetsrc: rename element to avfassetsrc (74.93 KB, patch)
2014-04-15 09:54 UTC, Matthieu Bouron
none Details | Review
0001-avfassetsrc-rename-references-to-iOS.patch ~ (1.33 KB, patch)
2014-04-18 18:21 UTC, Andoni Morales
none Details | Review
0002-avfassetsrc-downgrade-rank-to-SECONDARY-in-OS-X.patch (1.16 KB, patch)
2014-04-18 18:21 UTC, Andoni Morales
none Details | Review

Description Matthieu Bouron 2014-04-15 09:50:36 UTC
The following patchset port the iosavassetsrc element from the gstreamer-sdk 0.10 to 1.0.

Major changes from original code:
  * gst_task_(start|pause|stop) -> gst_pad_(start|pause|stop),
  * tasks are started directly in the READY=>PAUSED state change,
  * set_link functions removed,
  * handle SEEK query,
  * element is now build on OSX if AVFoundation framework is found

The latest patch rename the element to avfassetsrc, since it is available on both platform.
Comment 1 Matthieu Bouron 2014-04-15 09:53:01 UTC
Created attachment 274345 [details] [review]
applemedia: add new source/decoder element for iOS assets
Comment 2 Matthieu Bouron 2014-04-15 09:53:40 UTC
Created attachment 274346 [details] [review]
iosavassetsrc: Port to 1.0
Comment 3 Matthieu Bouron 2014-04-15 09:54:11 UTC
Created attachment 274347 [details] [review]
iosavassetsrc: rename element to avfassetsrc
Comment 4 Andoni Morales 2014-04-17 09:37:43 UTC
I will test and review it today
Comment 5 Andoni Morales 2014-04-18 18:19:00 UTC
I haven't been able to test seeking and I haven't tested it in iOS but the port looks good to me.
Comment 6 Andoni Morales 2014-04-18 18:21:02 UTC
Created attachment 274702 [details] [review]
0001-avfassetsrc-rename-references-to-iOS.patch ~
Comment 7 Andoni Morales 2014-04-18 18:21:50 UTC
Created attachment 274703 [details] [review]
0002-avfassetsrc-downgrade-rank-to-SECONDARY-in-OS-X.patch
Comment 8 Edward Hervey 2014-04-24 10:30:19 UTC
commit fc02ec2087d395697c06ea60944a0694cde958a9
Author: Andoni Morales Alastruey <ylatuya@gmail.com>
Date:   Fri Apr 18 20:04:25 2014 +0200

    avfassetsrc: downgrade rank to SECONDARY in OS X

commit d234bee52f2b5fb4775f22af2391907a00ac790b
Author: Andoni Morales Alastruey <ylatuya@gmail.com>
Date:   Fri Apr 18 20:03:48 2014 +0200

    avfassetsrc: rename references to iOS

commit 2f0aad7158dc4707c72dabda9330efe76728e42b
Author: Matthieu Bouron <matthieu.bouron@collabora.com>
Date:   Mon Apr 14 19:08:01 2014 +0100

    iosavassetsrc: rename element to avfassetsrc
    
    https://bugzilla.gnome.org/show_bug.cgi?id=728249

commit ecf765635b0a79f77ee8af9f0ca2d7b714334ddb
Author: Matthieu Bouron <matthieu.bouron@collabora.com>
Date:   Thu Apr 3 14:02:18 2014 +0100

    iosavassetsrc: Port to 1.0
    
    Also enables this element on OSX >= 10.7.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=728249

commit 9fec222b5aa8bcc24660a482e21bce91beb79fe9
Author: Andoni Morales Alastruey <ylatuya@gmail.com>
Date:   Sat May 11 03:41:36 2013 +0200

    applemedia: add new source/decoder element for iOS assets
    
    https://bugzilla.gnome.org/show_bug.cgi?id=728249