After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728241 - Recognize railway halts and tram stops as railway station place type
Recognize railway halts and tram stops as railway station place type
Status: RESOLVED FIXED
Product: geocode-glib
Classification: Other
Component: general
3.12.x
Other Linux
: Normal enhancement
: ---
Assigned To: geocode-glib maintainer(s)
geocode-glib maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-04-15 08:26 UTC by Marcus Lundblad
Modified: 2015-12-28 09:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
forward: expand railway station place type (1.30 KB, patch)
2014-04-15 10:43 UTC, Jonas Danielsson
committed Details | Review
Add light rail station place type (9.35 KB, patch)
2014-04-15 10:43 UTC, Jonas Danielsson
committed Details | Review
railway=halt (355.06 KB, image/png)
2014-04-15 10:57 UTC, Jonas Danielsson
  Details
railway=tram_stop (358.63 KB, image/png)
2014-04-15 10:57 UTC, Jonas Danielsson
  Details

Description Marcus Lundblad 2014-04-15 08:26:23 UTC
Currently geocode-glib handles nodes with key/value railway=station using the GEOCODE_PLACE_TYPE_RAILWAY_STATION place type.
Railway halts (simple stops) http://wiki.openstreetmap.org/wiki/Tag:railway%3Dhalt
and tram stops http://wiki.openstreetmap.org/wiki/Tag:railway%3Dtram_stop are currently not handled this way, and as a result shows up in gnome-maps search using a generic place icon.
Maybe these should be handled the same way as railway=station?

Perhaps there should be an addional place type for tram? The Mapbox icon set has a "light rail" icon.
What do you think?
Comment 1 Jonas Danielsson 2014-04-15 10:43:17 UTC
Created attachment 274349 [details] [review]
forward: expand railway station place type

Also include simpler train stops using the OSM 'halt' tag.
Comment 2 Jonas Danielsson 2014-04-15 10:43:21 UTC
Created attachment 274350 [details] [review]
Add light rail station place type

This type will also include tram stops.
Comment 3 Jonas Danielsson 2014-04-15 10:44:26 UTC
Maybe something like that? Are you able to test those patches, or have any locations you would like screenshots of?
Comment 4 Marcus Lundblad 2014-04-15 10:51:49 UTC
I don't have repository clones and build setups on my work laptop, but I could try it out at home tonight.
If you like to test, you could search for "Selknä", there should be a halt location (note that this is along a rail line with railway=preserved, which is not rendered by mapnik, this is a preserved tourist "museum" railway, but I think there should be other places with regular service of this type).
For trams, a search for "Solna Business Park", f.ex. will show two locations, where one is a tram stop.
Comment 5 Jonas Danielsson 2014-04-15 10:57:20 UTC
Created attachment 274351 [details]
railway=halt
Comment 6 Jonas Danielsson 2014-04-15 10:57:39 UTC
Created attachment 274352 [details]
railway=tram_stop
Comment 7 Marcus Lundblad 2014-04-15 11:00:50 UTC
Great!
That looks very nice!
Comment 8 Marcus Lundblad 2014-04-15 20:28:02 UTC
I tried building geocode-glib at my home machine.
I just ran a system installation of gnome-maps against the locally-compiled library (using LD_LIBRARY_PATH), it seems to work, I played around with it a bit.
Comment 9 Jonas Danielsson 2015-12-28 09:40:40 UTC
Attachment 274349 [details] pushed as 0fa8247 - forward: expand railway station place type
Attachment 274350 [details] pushed as 8686681 - Add light rail station place type