After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728204 - misc wayland fixes
misc wayland fixes
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-14 19:02 UTC by Ray Strode [halfline]
Modified: 2014-04-14 19:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
session: don't set DISPLAY for sessions that bring their own (4.42 KB, patch)
2014-04-14 19:02 UTC, Ray Strode [halfline]
committed Details | Review
session: drop remnants of WINDOWPATH (3.19 KB, patch)
2014-04-14 19:02 UTC, Ray Strode [halfline]
committed Details | Review
session: make sure session display mode is set even if session isn't explicitly picked (6.53 KB, patch)
2014-04-14 19:02 UTC, Ray Strode [halfline]
committed Details | Review

Description Ray Strode [halfline] 2014-04-14 19:02:26 UTC
Just a few things I noticed while working on making X start in the same way
wayland is started.
Comment 1 Ray Strode [halfline] 2014-04-14 19:02:28 UTC
Created attachment 274300 [details] [review]
session: don't set DISPLAY for sessions that bring their own

We only want to set DISPLAY if the user session is sharing the display
with the login screen.
Comment 2 Ray Strode [halfline] 2014-04-14 19:02:32 UTC
Created attachment 274301 [details] [review]
session: drop remnants of WINDOWPATH
Comment 3 Ray Strode [halfline] 2014-04-14 19:02:35 UTC
Created attachment 274302 [details] [review]
session: make sure session display mode is set even if session isn't explicitly picked

Right now we we only set the display mode when a user picks a session
from the session list.  That means the wrong display mode will get used
if wayland is saved from a previous log in.

This commit makes sure the display mode gets set as soon as the user
credentials are established, since at the point log in is imminent.
Comment 4 Ray Strode [halfline] 2014-04-14 19:03:12 UTC
Attachment 274300 [details] pushed as ce40d34 - session: don't set DISPLAY for sessions that bring their own
Attachment 274301 [details] pushed as 6e1f486 - session: drop remnants of WINDOWPATH
Attachment 274302 [details] pushed as 2860eb3 - session: make sure session display mode is set even if session isn't explicitly picked