After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728154 - libgstmpegts is included in multiple categories
libgstmpegts is included in multiple categories
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: packages
git master
Other Linux
: Normal blocker
: 1.3.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-14 07:32 UTC by Sebastian Dröge (slomo)
Modified: 2014-06-28 08:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gst-plugins-bad: Handle libraries (4.25 KB, patch)
2014-06-13 06:35 UTC, Edward Hervey
needs-work Details | Review
gst-plugins-bad: Handle libraries (4.25 KB, patch)
2014-06-16 14:02 UTC, Edward Hervey
none Details | Review
packages: Update for gst-plugins-bad libraries (3.60 KB, patch)
2014-06-16 14:02 UTC, Edward Hervey
none Details | Review

Description Sebastian Dröge (slomo) 2014-04-14 07:32:11 UTC
Currently libgstmpegts is included in multiple categories because it's needed by the dvb plugin and the tsdemux plugin. This needs to be fixed.

For Android this only shows up as the following warnings, for other packaging systems it is going to cause failures:

-----> Creating package for gstreamer-1.0
./cerbero/packages/android.py:73: UserWarning: Duplicate name: 'lib/libgstmpegts-1.0.so.0'
  compress_type=zipfile.ZIP_DEFLATED)
./cerbero/packages/android.py:73: UserWarning: Duplicate name: 'lib/libgstmpegts-1.0.so.0.300.0'
  compress_type=zipfile.ZIP_DEFLATED)
./cerbero/packages/android.py:73: UserWarning: Duplicate name: 'lib/libgstmpegts-1.0.a'
  compress_type=zipfile.ZIP_DEFLATED)
./cerbero/packages/android.py:73: UserWarning: Duplicate name: 'lib/libgstmpegts-1.0.la'
  compress_type=zipfile.ZIP_DEFLATED)
Comment 1 Edward Hervey 2014-05-20 06:03:19 UTC
What solution should we use ?

* Make the -bad library a dependency of the -bad plugins package ?
* Create a separate -dvb plugins package which depends on this ?
Comment 2 Edward Hervey 2014-06-13 06:35:20 UTC
Created attachment 278386 [details] [review]
gst-plugins-bad: Handle libraries
Comment 3 Sebastian Dröge (slomo) 2014-06-13 06:48:59 UTC
Review of attachment 278386 [details] [review]:

::: recipes/gst-plugins-bad-1.0.recipe
@@ +18,3 @@
+    files_libs = ['libgstcodecparsers-1.0', 'libgstmpegts-1.0', 'libgsturidownloader-1.0',
+                  'libgstbasecamerabinsrc-1.0', 'libgstphotography-1.0',
+                  'libgstgl-1.0']

Now you just need to use the libs category in one of the .package files... and let all the packages that contain a plugin using those libraries depend on that package
Comment 4 Edward Hervey 2014-06-16 14:02:28 UTC
Created attachment 278545 [details] [review]
gst-plugins-bad: Handle libraries
Comment 5 Edward Hervey 2014-06-16 14:02:32 UTC
Created attachment 278546 [details] [review]
packages: Update for gst-plugins-bad libraries
Comment 6 Edward Hervey 2014-06-23 07:37:25 UTC
commit ce92730c24af514dd6b4845db17eee91bd736064
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Mon Jun 16 15:41:22 2014 +0200

    packages: Update for gst-plugins-bad libraries
    
    https://bugzilla.gnome.org/show_bug.cgi?id=728154

commit 8808447f0fa99f0228e6e6cabfe9bc326f643263
Author: Edward Hervey <edward@collabora.com>
Date:   Fri Jun 13 08:34:23 2014 +0200

    gst-plugins-bad: Handle libraries
    
    https://bugzilla.gnome.org/show_bug.cgi?id=728154
Comment 7 Edward Hervey 2014-06-24 06:35:53 UTC
Comment from Andoni:
"""
I don't think this set of patches is correct from the point of view of the packages. This would include the -bad libraries in several packages, ending up with duplicated files, which is a problem for .deb and .rpm packages as it will complain about the same file being installed by several packages.
I think the correct way of handling this is adding the gst-plugins-bad:libs to the gstreamer-core package, which includes the libraries from gstreamer and gstreamer-base.
"""
Comment 8 Edward Hervey 2014-06-24 07:30:57 UTC
commit afa2a3eca532638e2b83b85d66c387249500ecd3
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Tue Jun 24 08:39:39 2014 +0200

    packages: Use gst-plugins-base-1.0:libs where needed
    
    It contains a set of libraries which should only be dist'ed once
    
    https://bugzilla.gnome.org/show_bug.cgi?id=728154