After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728135 - gtk_widget_set_visible's nothing-changed-check
gtk_widget_set_visible's nothing-changed-check
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal trivial
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-04-13 21:26 UTC by Morten Welinder
Modified: 2014-05-11 15:57 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Morten Welinder 2014-04-13 21:26:12 UTC
gtk_widget_set_visible's nothing-changed-check is...

1. Duplicate.  gtk_widget_show and gtk_widget_hide already do this.

2. Fooled by non-canonical booleans (like 32) that happen with flag checks.

Suggestion: remove the check.