GNOME Bugzilla – Bug 728084
Missing padding between gear button and search entry
Last modified: 2014-04-14 20:42:16 UTC
Created attachment 274162 [details] screenshot.png gnome-maps-3.12.0-1.fc20.x86_64 Only visible at small sizes.
Created attachment 274163 [details] Screenshot yes, On my system(fedora 20) also with the updated repository there is no padding.
Created attachment 274168 [details] [review] mainWindow : add left & right margin space to search bar. A margin of 5 is set to both left and right side of the search bar. Because buttons can be on either side.
Review of attachment 274168 [details] [review]: Looks fine to me.
Review of attachment 274168 [details] [review]: Thanks for the patch Rishi! I guess this should be applied both to master and the 3-12 branch. I have some comments below. And also I would like a better commit log, maybe: mainWindow: Add padding to search entry ::: src/main-window.ui @@ +40,3 @@ <property name="width-request">500</property> + <property name="margin-left">5</property> + <property name="margin-right">5</property> margin-{left,right} is deprecated since gtk+ 3.12 we should use margin-{start,end} instead. And also I think we might want to set 6 instead of 5 since that is the default padding of the GtkHeaderBar. That's what the padding seem to be between the layer-button and the user-location button (on git master). Why that is not honored in the searchbar case I am not sure. Is it because of the explicit width-request?
Created attachment 274260 [details] [review] mainWindow : add padding to search entry. Thanks for the review. I followed the documentation at http://www.roojs.org/seed/gir-1.2-gtk-3.0/seed/Gtk.SearchEntry.html but I see its outdated. Changed to margin-{start,end} as per https://developer.gnome.org/gtk3/stable/GtkWidget.html. Yes, 6 seems to be the default padding, and also between layer and user-location button. Since the width-request for search entry was 500, I thought keeping 5 would be fine, but 6 is better.
Thanks Rishi! This will be in 3.12.1 as well as in master.