After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728073 - Allow defining an invisible resize area for GtkPaned's handle
Allow defining an invisible resize area for GtkPaned's handle
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-04-12 03:19 UTC by Victor Eduardo
Modified: 2014-04-26 01:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
initial patch (2.29 KB, patch)
2014-04-12 03:21 UTC, Victor Eduardo
committed Details | Review

Description Victor Eduardo 2014-04-12 03:19:37 UTC
This would allow theme developers to use a very small width for the resize handle, but still let users easily move the pane separator by defining a wider resize area.

For instance, a theme developer could set "handle-size" to 1px, but also set a "margin" of 3px so that 3 additional pixels are added at each side of the pane separator, allowing easier resizing.

The additional (invisible) resize area could use the "margin" style property.
Comment 1 Victor Eduardo 2014-04-12 03:21:30 UTC
Created attachment 274147 [details] [review]
initial patch
Comment 2 Matthias Clasen 2014-04-13 19:46:10 UTC
Review of attachment 274147 [details] [review]:

The patch works fine in my testing. Not sure if margin is 100% the right thing to use here.
Comment 3 Victor Eduardo 2014-04-14 01:43:11 UTC
Thanks for the review Matthias.

I wasn't sure about introducing a new style property for GtkPaned or using 'margin', so I spoke to Daniel Foré from elementary and he suggested using 'margin', since that's what client-side decorations appear to be using for the invisible grip area.

Looking at the patch again, I'm not sure if I should have added STYLE_CLASS_PANE_SEPARATOR to the style context before calling gtk_style_context_get_margin. Would that be correct?
Comment 4 Allan Day 2014-04-16 08:41:51 UTC
I'd welcome this from a design point of view. The resize handles look ugly, and the invisible drag area has been shown to work - that's what we do for windows now, instead of having a handle in the corner, for example.

This was actually something that I was hoping to pursue myself, so I'm happy that it's already happening. :)
Comment 5 Matthias Clasen 2014-04-21 11:39:56 UTC
Review of attachment 274147 [details] [review]:

lets go with this, at least for now
Comment 6 Allan Day 2014-04-23 08:54:17 UTC
Thanks for the patch, Victor! I'm looking forward to seeing this (or rather, not seeing those handles). :)
Comment 7 Victor Eduardo 2014-04-26 01:24:09 UTC
You're welcome, Allan! :)