After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727903 - structure: handle 0 denominator
structure: handle 0 denominator
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-09 15:27 UTC by Vincent Penquerc'h
Modified: 2014-04-10 08:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
arbitrary target version (1022 bytes, patch)
2014-04-09 15:28 UTC, Vincent Penquerc'h 		none Details | Review
error out version (895 bytes, patch)
2014-04-09 15:28 UTC, Vincent Penquerc'h 		none Details | Review
error out on 0 target denominator (828 bytes, patch)
2014-04-09 16:03 UTC, Vincent Penquerc'h 		none Details | Review
newest patch (833 bytes, patch)
2014-04-09 16:22 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2014-04-09 15:27:49 UTC 
Two patches, either use arbitrary target, or error out. Not sure which one people would prefer the behavior to be.
Comment 1 Vincent Penquerc'h 2014-04-09 15:28:20 UTC 
Created attachment 273907 [details] [review]
arbitrary target version
Comment 2 Vincent Penquerc'h 2014-04-09 15:28:51 UTC 
Created attachment 273908 [details] [review]
error out version
Comment 3 Tim-Philipp Müller 2014-04-09 15:42:00 UTC 
How about neither of those? I would say passing a 0 denominator is a programming error.
Comment 4 Vincent Penquerc'h 2014-04-09 16:03:07 UTC 
Created attachment 273913 [details] [review]
error out on 0 target denominator

So more like this ?
Comment 5 Tim-Philipp Müller 2014-04-09 16:12:46 UTC 
Yeah, IMHO anyway. (But please write it as "target_denominator != 0" instead of just "target_denominator")
Comment 6 Vincent Penquerc'h 2014-04-09 16:22:23 UTC 
Created attachment 273914 [details] [review]
newest patch

Updated so. I'll push that soon if nobody else objects.
Comment 7 Vincent Penquerc'h 2014-04-10 08:49:57 UTC 
commit 876af7b343e62eea38abb73c0ee14b7542e5b37f
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Wed Apr 9 17:01:01 2014 +0100

    structure: error out when trying to fixate a fraction near an invalid target