After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727800 - MainWindow: make clicking the map grab focus
MainWindow: make clicking the map grab focus
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-08 08:03 UTC by Dario Di Nucci
Modified: 2014-04-08 09:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
MainWindow: make clicking the map grab focus (1.09 KB, patch)
2014-04-08 08:03 UTC, Dario Di Nucci 		none Details | Review
MainWindow: make clicking the map grab focus (1.05 KB, patch)
2014-04-08 08:11 UTC, Dario Di Nucci 		committed Details | Review

Description Dario Di Nucci 2014-04-08 08:03:01 UTC 
Fix map grab focus after clicking on it (see 57e2e3fc466245307cc457becd1c961958a9a462) broken by a previous commit (531c44191e20610c53cbdf526cad4d7d2ba4690f).
Comment 1 Dario Di Nucci 2014-04-08 08:03:03 UTC 
Created attachment 273765 [details] [review]
MainWindow: make clicking the map grab focus
Comment 2 Dario Di Nucci 2014-04-08 08:11:13 UTC 
Created attachment 273767 [details] [review]
MainWindow: make clicking the map grab focus

Fix map grab focus after clicking on it broken by a previous commit.
(531c44191e20610c53cbdf526cad4d7d2ba4690f)
Comment 3 Jonas Danielsson 2014-04-08 09:03:17 UTC 
Review of attachment 273767 [details] [review]:

Thanks Dario!

I will commit this with the minor change below.

::: src/application.js
@@ +108,3 @@
             return;
 
+        let overlay = new Gtk.Overlay({ visible: true, 'can-focus': true });

should be: new Gtk.Overlay({ visible: true, can_focus: true });