GNOME Bugzilla – Bug 727754
Enhancements to porting guide documentation
Last modified: 2014-04-28 09:55:14 UTC
Created attachment 273716 [details] [review] Porting guide update A few tidbits of documentation which might be useful for fellow coders porting to GStreamer 1.0
Looks good to me. Helpful additions to the docs. Should we push?
Comment on attachment 273716 [details] [review] Porting guide update > docs/random/porting-to-1.0.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) Please provide a patch in 'git format-patch' format, so that we can just apply it with 'git am' and it already contains author info and a commit message. >diff --git a/docs/random/porting-to-1.0.txt b/docs/random/porting-to-1.0.txt >index 341d9f9..3e83119 100644 >--- a/docs/random/porting-to-1.0.txt >+++ b/docs/random/porting-to-1.0.txt >@@ -716,6 +716,9 @@ CHANGES > garbled). Since 1.0.7 the "iradio-mode" property has been re-added > to allow users to switch off the default behaviour of requesting > icecast metadata. >+ - fakesink's "silent" property default value changed from FALSE to TRUE. >+ This means that "gst-launch-1.0 -v" will not show messages from >+ fakesink unless you explicitly request them with "fakesink silent=0". - same is also true for the identity element (and, less importantly, also fakesrc). - the explicit request should be via silent=false, it's a boolean not an integer (although =0 will work too). - should also mention why it was changed (for efficiency reasons) >@@ -739,6 +742,12 @@ CHANGES > > playbin uri=file:///path/to/foo.flac audio-sink=pulsesink > >+ * non-time-based sources do not provide timestamps anymore >+ >+ - Sources based on BYTEs instead of TIME (like filesrc or souphttpsrc) >+ do not provide PTS anymore. In the 0.10 API they provided a PTS with >+ value 0 for the first buffer. This was needed for legacy operation but >+ has been removed in the 1.0 API. This is not wrong, but also a bit misleading. Sources that output stuff in BYTE format will usually still put a DTS=0 on the first buffer even if PTS is unset.
Created attachment 275301 [details] [review] Enhancements to porting guide documentation
Pushed, thanks: commit 3b617f1fb22fd5d6bc14e79a2925ad149d2e350c Author: Xavi Artigas <xartigas@fluendo.com> Date: Mon Apr 28 10:14:50 2014 +0200 docs: enhancements to porting guide documentation https://bugzilla.gnome.org/show_bug.cgi?id=727754 Although I'm still a bit confused about the bit with the sources, because nothing has changed there really in principle, it's just that it only sets DTS to 0 and not PTS and in 0.10 there was no such distinction. But I guess it's good to mention, you seem to have run into that somewhere.
Yes, I had a plugin relying on that 0 PTS in the absence of any other time marker, and it disappeared in 1.0. It's no big deal, but yeah, I too think it is good to mention. Thanks for the review!