After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727624 - [unity] gtk-3.10 branch looks ugly
[unity] gtk-3.10 branch looks ugly
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: ux
master
Other Linux
: High normal
: 0.8.0
Assigned To: Geary Maintainers
Geary Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-04 21:42 UTC by Jim Nelson
Modified: 2014-05-13 17:41 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jim Nelson 2014-04-04 21:42:57 UTC
I've updated the gtk-3.10 branch to merge in master.  It looks good under GNOME Shell but not so great under Unity (under Trusty 14.04, today's beta).

There's a general problem with GtkHeaderBar under Trusty which we also faced in California (bug #726075).  I'm about to land a patch in the gtk-3.10 branch which uses a similar technique to fix the problem for Geary.

However, even with that in place, there remains several visual glitches which we need to resolve before landing this branch in master:

* The labels in the icons with labels (Archive, Trash) are too close to the icon.  This may be related to bug #713483.

* Geary is no longer draggable by press-and-holding the toolbar (which is now a GtkHeaderBar).  California has a similar issue, so it's conceivable to live with this, but it would be nice to restore this functionality.

* The GtkHeaderBar title and subtitle appear crowded compared to their appearance under GNOME Shell.

The first item is a must-have to land this in master (as noted, it's possible Yosef's patch will solve that problem).  The second is highly desirable, the third is nice-to-have.
Comment 1 Jim Nelson 2014-04-04 21:58:50 UTC
The --enable-unity flag and changes have been pushed to gtk-3.10, commit b86477.
Comment 2 Matthias Clasen 2014-04-05 03:30:55 UTC
(In reply to comment #0)

> * Geary is no longer draggable by press-and-holding the toolbar (which is now a

If you mean touch with this, that has been fixed (sortof) in 3.12. We could look at backporting that fix to 3.10 if it would help
Comment 3 Jim Nelson 2014-04-09 22:41:33 UTC
That would help, but it's not as critical as the first bug mentioned above.  It is good to know this isn't our bug -- can you tell me which commit/bug # is tied to the fix?
Comment 4 Matthias Clasen 2014-04-10 21:26:48 UTC
bug 709914
Comment 5 Jim Nelson 2014-05-13 02:22:45 UTC
Matthias, I'm late in responding, but it would be great if that could be backported to 3.10, if the GTK team plans another dot release.

The third problem (crowded labels in GtkHeaderBar under Unity) doesn't look to be easily fixed without using a custom title widget, which is asking for a lot due to what appears to be a theme issue.  I'm not inclined to worry about it at this moment.

I've fixed the toolbar spacing problem under Unity and, as an added bonus, moved the Archive/Trash buttons to the right side of the toolbar, to the left of the search bar.  There has been some user requests about moving these buttons close to the conversation viewer, so this is a step in that direction.

Pushed to master, commit f0f47b
Comment 6 Matthias Clasen 2014-05-13 14:39:16 UTC
Yesterdays 3.10.9 release has the touch dragging fix:
https://download.gnome.org/sources/gtk+/3.10/gtk+-3.10.9.tar.xz

Hope that helps.
Comment 7 Jim Nelson 2014-05-13 17:41:52 UTC
Yes!  Thank you.