After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727579 - The Input Method candidates window will obscure the current text
The Input Method candidates window will obscure the current text
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.12.x
Other Linux
: Normal major
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-04 02:49 UTC by Peng Wu
Modified: 2014-04-14 04:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gedit 3.12 screenshot (101.06 KB, image/png)
2014-04-04 02:51 UTC, Peng Wu
  Details
gedit 3.10 screenshot (28.89 KB, image/png)
2014-04-04 02:52 UTC, Peng Wu
  Details
layout: Change setDummyCursorPosition to also set the size (3.13 KB, patch)
2014-04-11 14:20 UTC, Rui Matos
committed Details | Review

Description Peng Wu 2014-04-04 02:49:52 UTC
In gnome shell 3.12, the Input Method candidates window will cover the underlying inputting text, which will interfere with the user inputting behavior.

Please move the candidates window lower, then the user can see the current inputting text.

I used Fedora 20 + Gnome 3.12 Fedora Copr.
Version: gnome-shell-3.12.0-1.fc20.x86_64 ibus-1.5.6-1.fc20.x86_64
Comment 1 Peng Wu 2014-04-04 02:51:32 UTC
Created attachment 273563 [details]
gedit 3.12 screenshot
Comment 2 Peng Wu 2014-04-04 02:52:11 UTC
Created attachment 273564 [details]
gedit 3.10 screenshot
Comment 3 Rui Matos 2014-04-11 14:20:39 UTC
Created attachment 274109 [details] [review]
layout: Change setDummyCursorPosition to also set the size

If we are being used to follow a text entry cursor we also need to set
the size so that the popup menu avoids covering it.
--

This breaks the API but I doubt any extension is using it already
since it's new in 3.12 . I'd like to get this in 3.12.1
Comment 4 Florian Müllner 2014-04-11 14:36:01 UTC
Review of attachment 274109 [details] [review]:

Not particularly fond of the "setDummyCursor" name, otherwise looks good to me.

::: js/ui/layout.js
@@ +730,3 @@
     },
 
+    // setDummyCursor:

Maybe "setDummyCursorGeometry"?
Comment 5 Rui Matos 2014-04-11 14:56:53 UTC
Pushed with Geometry appended to both master and 3.12. Bonus points
for strlen("Geometry") == strlen("Position") .

Attachment 274109 [details] pushed as e2ccbe5 - layout: Change setDummyCursorPosition to also set the size
Comment 6 Peng Wu 2014-04-14 04:29:53 UTC
Thanks for the patch!