GNOME Bugzilla – Bug 727371
Conform to PEP8 1.5.1's check for E265 (missing whitespace after inline comment symbol)
Last modified: 2015-10-20 13:19:42 UTC
Since I upgraded to PEP8 1.5.1, every time I try to commit I receive these messages (e.g.): ./pitivi/mainwindow.py:496:1: E265 block comment should start with '# ' ./pitivi/mainwindow.py:506:1: E265 block comment should start with '# ' ./pitivi/mainwindow.py:554:1: E265 block comment should start with '# ' ./pitivi/mainwindow.py:726:9: E265 block comment should start with '# ' ./pitivi/mainwindow.py:727:9: E265 block comment should start with '# ' ./pitivi/mainwindow.py:767:9: E265 block comment should start with '# ' ./pitivi/mainwindow.py:768:9: E265 block comment should start with '# ' ./pitivi/mainwindow.py:940:13: E265 block comment should start with '# ' ./pitivi/mainwindow.py:1017:9: E265 block comment should start with '# ' ./pitivi/mainwindow.py:1018:9: E265 block comment should start with '# ' ./pitivi/mainwindow.py:1055:1: E265 block comment should start with '# ' ./pitivi/mainwindow.py:1076:13: E265 block comment should start with '# ' ./pitivi/mainwindow.py:1077:13: E265 block comment should start with '# ' ./pitivi/mainwindow.py:1102:1: E265 block comment should start with '# ' Note, however, that this is not modified code.
Created attachment 273314 [details] [review] Proposed fix Proposed fix.
As far as I understand it, E265 is just enforcing the rule where #this comment is invalid but # This comment is valid, as it has a whitespace after the "#" ...which seems like good practice/something that helps legibility. If my understanding is correct, I'd be in favor of correcting these offending comments across the codebase rather than ignoring that error ;)
Review of attachment 273314 [details] [review]: As per the last comment, and since there were no objections/follow-up comments... better to fix the problem than hide the warning!
This bug has been migrated to https://phabricator.freedesktop.org/T3178. Please use the Phabricator interface to report further bugs by creating a task and associating it with Project: Pitivi. See http://wiki.pitivi.org/wiki/Bug_reporting for details.