After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727205 - Crash if Facebook credentials expired
Crash if Facebook credentials expired
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.12.x
Other All
: Normal critical
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
: 727355 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-03-28 04:22 UTC by Torsten Scholak
Modified: 2014-04-15 14:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
facebook-item: Bail out as soon as there is an error (1.83 KB, patch)
2014-04-15 12:09 UTC, Debarshi Ray 		committed Details | Review
facebook-item: Handle failures gracefully without aborting (7.37 KB, patch)
2014-04-15 13:25 UTC, Debarshi Ray 		committed Details | Review
facebook-item: Plug a memory leak (1.15 KB, patch)
2014-04-15 13:25 UTC, Debarshi Ray 		committed Details | Review

Description Torsten Scholak 2014-03-28 04:22:50 UTC 
When the facebook credentials expired, I got:

** (gnome-photos:10722): ERROR **: Can't get the photo from the Facebook Graph
Trace/breakpoint trap

Although renewing the facebook authorization in GOA solves the problem, I believe Photos should not crash.
Comment 1 Torsten Scholak 2014-03-28 04:23:50 UTC 
I also see

(gnome-photos:10722): GLib-WARNING **: GError set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
The overwriting error message was: Bad Request

on the console, I don't know whether that's related, though.
Comment 2 André Klapper 2014-03-28 13:50:13 UTC 
Can you please provide a stacktrace of the crash?
Comment 3 Torsten Scholak 2014-03-28 14:50:23 UTC 
In order to do that, I'd have to wait until my Facebook credentials expire again.
Do you know how to speed this up?
Comment 4 Torsten Scholak 2014-03-29 03:26:08 UTC 
I was able to reproduce the error by removing the Gnome app in facebook's "App Settings" and then restarting gnome-photos. Here is the backtrace:

+ Trace 233408

  • #0 g_logv
    at /var/tmp/portage/dev-libs/glib-2.39.92/work/glib-2.39.92/glib/gmessages.c line 1038
  • #1 g_log
    at /var/tmp/portage/dev-libs/glib-2.39.92/work/glib-2.39.92/glib/gmessages.c line 1071
  • #2 photos_facebook_item_create_thumbnail
  • #3 photos_base_item_create_thumbnail_in_thread_func
  • #4 g_thread_pool_thread_proxy
    at /var/tmp/portage/dev-libs/glib-2.39.92/work/glib-2.39.92/glib/gthreadpool.c line 307
  • #5 g_thread_proxy
    at /var/tmp/portage/dev-libs/glib-2.39.92/work/glib-2.39.92/glib/gthread.c line 764
  • #6 start_thread
    at pthread_create.c line 308
  • #7 clone
    at ../sysdeps/unix/sysv/linux/x86_64/clone.S line 113 






Comment 5


Debarshi Ray





          2014-04-01 11:47:38 UTC
        



*** Bug 727355 has been marked as a duplicate of this bug. ***






Comment 6


Debarshi Ray





          2014-04-15 12:01:58 UTC
        



There is another related issue here. Just before it crashes you see this in the terminal:

(gnome-photos:9108): GLib-WARNING **: GError set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
The overwriting error message was: Bad Request






Comment 7


Debarshi Ray





          2014-04-15 12:09:43 UTC
        



Created attachment 274356 [details] [review]
facebook-item: Bail out as soon as there is an error






Comment 8


Debarshi Ray





          2014-04-15 13:25:19 UTC
        



Created attachment 274365 [details] [review]
facebook-item: Handle failures gracefully without aborting






Comment 9


Debarshi Ray





          2014-04-15 13:25:53 UTC
        



Created attachment 274366 [details] [review]
facebook-item: Plug a memory leak






Comment 10


Debarshi Ray





          2014-04-15 14:02:36 UTC
        



Review of attachment 274356 [details] [review]:

Committed.






Comment 11


Debarshi Ray





          2014-04-15 14:04:41 UTC
        



Review of attachment 274365 [details] [review]:

Committed.






Comment 12


Debarshi Ray





          2014-04-15 14:05:28 UTC
        



Review of attachment 274366 [details] [review]:

Committed.