GNOME Bugzilla – Bug 727205
Crash if Facebook credentials expired
Last modified: 2014-04-15 14:40:21 UTC
When the facebook credentials expired, I got: ** (gnome-photos:10722): ERROR **: Can't get the photo from the Facebook Graph Trace/breakpoint trap Although renewing the facebook authorization in GOA solves the problem, I believe Photos should not crash.
I also see (gnome-photos:10722): GLib-WARNING **: GError set over the top of a previous GError or uninitialized memory. This indicates a bug in someone's code. You must ensure an error is NULL before it's set. The overwriting error message was: Bad Request on the console, I don't know whether that's related, though.
Can you please provide a stacktrace of the crash?
In order to do that, I'd have to wait until my Facebook credentials expire again. Do you know how to speed this up?
I was able to reproduce the error by removing the Gnome app in facebook's "App Settings" and then restarting gnome-photos. Here is the backtrace:
+ Trace 233408
*** Bug 727355 has been marked as a duplicate of this bug. ***
There is another related issue here. Just before it crashes you see this in the terminal: (gnome-photos:9108): GLib-WARNING **: GError set over the top of a previous GError or uninitialized memory. This indicates a bug in someone's code. You must ensure an error is NULL before it's set. The overwriting error message was: Bad Request
Created attachment 274356 [details] [review] facebook-item: Bail out as soon as there is an error
Created attachment 274365 [details] [review] facebook-item: Handle failures gracefully without aborting
Created attachment 274366 [details] [review] facebook-item: Plug a memory leak
Review of attachment 274356 [details] [review]: Committed.
Review of attachment 274365 [details] [review]: Committed.
Review of attachment 274366 [details] [review]: Committed.