After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727163 - 'Connecting' labels inconsistent
'Connecting' labels inconsistent
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: system-status
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-27 14:16 UTC by Paul Lange
Modified: 2014-04-21 20:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot showing the problem (95.57 KB, image/png)
2014-03-27 14:16 UTC, Paul Lange 		  Details
patch (2.59 KB, patch)
2014-04-04 11:34 UTC, Paul Lange 		needs-work Details | Review
better commit message (2.68 KB, patch)
2014-04-04 16:03 UTC, Paul Lange 		committed Details | Review

Description Paul Lange 2014-03-27 14:16:37 UTC 
Created attachment 273094 [details]
screenshot showing the problem

The labels for wired and wireless connections when connecting are inconsistent. See the attached screenshot.
Comment 1 Paul Lange 2014-04-04 11:34:27 UTC 
Created attachment 273581 [details] [review]
patch

A first try for a patch. Comments welcome!

All other labels in the status menu are capitalised and don't use dots, that what I did here.
Comment 2 drago01 2014-04-04 11:50:02 UTC 
Review of attachment 273581 [details] [review]:

Please add a proper subject and commit message (and include a link to the bug in the message).
Comment 3 Paul Lange 2014-04-04 16:03:09 UTC 
Created attachment 273593 [details] [review]
better commit message

Thanks for the review. Changes the subject and added a link to bugzilla.
Comment 4 Florian Müllner 2014-04-04 16:44:11 UTC 
Looks good to me, provided those are the strings we are going for. In any case the patch will either need approval from the l10n and documentation teams or wait until gnome-3-12 is branched off master.
Comment 5 Allan Day 2014-04-07 09:34:54 UTC 
"Connecting" and "Disconnecting" look tidier to me, so +1 from a design point of view.
Comment 6 Magdalen Berns (irc magpie) 2014-04-13 01:40:55 UTC 
Review of attachment 273593 [details] [review]:

I like it.

What do the maintainers think?
Comment 7 drago01 2014-04-13 07:32:34 UTC 
Review of attachment 273593 [details] [review]:

We have branched now so feel free to push.
Comment 8 Paul Lange 2014-04-21 19:45:29 UTC 
Thanks for the reviews. I don't have commit rights, so someone else needs to commit.