GNOME Bugzilla – Bug 727132
Binaries won't report program version
Last modified: 2014-04-11 16:53:53 UTC
GVFS will not report it's version using -v -V or --version. For this reason I cannot determine the version of GVFS installed. I tried gvfs-ls, and one of the other binaries. Basically this means that without package management software, a user cannot find out what version of the software is running. As an aside, there is also no manpage installed. I recommend adding the program functionality to report the version. I can't even accurately report the version I am using due to this bug.
A slightly confusing point here is that gvfs is split into a number of components which need not be the same version. Still, I think it would be useful if the binaries could report their version (although bear in mind that the gvfs-* binaries are not gvfs specific and may still move into the glib/gio tree). gvfs has had manpages since 1.13.3, July 2012, so I can tell you that your gvfs is at least older than that :-)
Since gvfsd-http uses the version number as a user-agent, you can figure it out in the meantime with this: strings /usr/lib/gvfs/gvfsd-http | less And then look for something like: gvfs/1.18.3
Apparently there is no gvfsd-http in this install either. I can say it is whatever comes with Slackware 14.0. I recommend some kind of way to determine the release version independent of package management, even if it prints a pointer to --version a more core piece of the gvfs package. Installed binaries are: gvfs-cat gvfs-mkdir gvfs-rename gvfs-copy gvfs-monitor-dir gvfs-rm gvfs-info gvfs-monitor-file gvfs-save gvfs-less gvfs-mount gvfs-set-attribute gvfs-ls gvfs-move gvfs-trash gvfs-mime gvfs-open gvfs-tree
Created attachment 273107 [details] [review] Report gvfs version when --version is used
Review of attachment 273107 [details] [review]: Thanks, looks good, just few notes... I don't thing so we need to put it in meta-* files, because they aren't distribute. Man pages should be also updated accordingly. ::: daemon/main.c @@ +190,3 @@ + if (show_version) + { + g_print(PACKAGE_STRING "\n"); I know it's annoying, but insert space before opening parenthesis to be consistent across files, please fix it also in other files... ::: programs/gvfs-cat.c @@ +37,3 @@ static GOptionEntry entries[] = { + { "version", 0, 0, G_OPTION_ARG_NONE, &show_version, N_("Show program version"), NULL}, + { G_OPTION_REMAINING, 0, 0, G_OPTION_ARG_FILENAME_ARRAY, &locations, NULL, NULL }, You have duplicated this line by mistake.
Created attachment 273230 [details] [review] Report gvfs version when --version is used
The updated patch should fixes those issues.
Review of attachment 273230 [details] [review]: Looks good to me, thanks!
Pushed to master as a29366193100de48df416c07f96daf7b84ee8f30. Thanks!