After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727025 - adder: rework the logic to check if eos has to be sent.
adder: rework the logic to check if eos has to be sent.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.2.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-25 16:14 UTC by Mathieu Duponchelle
Modified: 2014-04-12 13:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fixes the reported issue (2.21 KB, patch)
2014-03-25 16:15 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2014-03-25 16:14:36 UTC 
Checking the available size is incorrect, as in certain situations one can get a buffer with size 0.

The per-pad infos of the EOS state are available, and this patch replicates audiomixer's logic.
Comment 1 Mathieu Duponchelle 2014-03-25 16:15:25 UTC 
Created attachment 272866 [details] [review]
fixes the reported issue
Comment 2 Mathieu Duponchelle 2014-04-08 12:20:34 UTC 
commit 6954d2167cf215907138983b99e443eae6b4d315
Author: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Date:   Tue Mar 25 17:11:34 2014 +0100

    adder: rework the logic to check if eos has to be sent.
    
    Checking the size available was incorrect, and the infos
    for per-pad EOS are available.
    
    Same logic as audiomixer.
    
    fixes: https://bugzilla.gnome.org/show_bug.cgi?id=727025