After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726873 - rtsp-threadpool: Improve code coverage of check tests
rtsp-threadpool: Improve code coverage of check tests
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other All
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-22 12:29 UTC by Sebastian Rasmussen
Modified: 2014-03-24 00:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch improving code coverage of rtsp-threadpool tests. (6.78 KB, patch)
2014-03-22 12:31 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-03-22 12:29:48 UTC 
The attached patch raises code coverage of rtsp-threadpool from 73.1% to 91.8%.
It also make existing tests us the provided macros for testing the type of an object. This is an improvement over != NULL and == NULL checks.
Comment 1 Sebastian Rasmussen 2014-03-22 12:31:37 UTC 
Created attachment 272627 [details] [review]
Proposed patch improving code coverage of rtsp-threadpool tests.
Comment 2 Tim-Philipp Müller 2014-03-24 00:49:11 UTC 
Pushed, thanks!

commit d9cfa3677bb2b4103be2e9439eced577893eda82
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Sat Mar 22 13:24:27 2014 +0100

    tests: Improve code coverage of rtsp-threadpool tests
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=726873