Created attachment 272447 [details] [review]
This patch corrects the observed bug.

Review of attachment 272447 [details] [review]:

::: gst-libs/gst/codecparsers/gsth264parser.c
@@ -1346,3 @@
 
-    if (parse_vui_params && vui->fixed_frame_rate_flag &&
-        sps->frame_mbs_only_flag && !vui->pic_struct_present_flag) {

Can you explain the reasoning a bit more? Why remove these two checks here, what do these flags mean and why can't they be ignored?

(In reply to comment #2)
> Review of attachment 272447 [details] [review]:
> 
> ::: gst-libs/gst/codecparsers/gsth264parser.c
> @@ -1346,3 @@
> 
> -    if (parse_vui_params && vui->fixed_frame_rate_flag &&
> -        sps->frame_mbs_only_flag && !vui->pic_struct_present_flag) {
> 
> Can you explain the reasoning a bit more? Why remove these two checks here,
> what do these flags mean and why can't they be ignored?

Basically the frame_mbs_only_flag determine whether the stream is interlaced or not and pic_struct_present_flag will tell whether timestamps can be computed for each frame, but in all cases the framerate is contained in the stream and can be used. At least this is how I understand it.

This thread may be more or less linked to https://bugzilla.gnome.org/show_bug.cgi?id=723352

commit 15d00a32fd5dabf1a2186bde402f179cc1db1076
Author: Thibault Saunier <tsaunier@gnome.org>
Date:   Mon Mar 17 16:39:42 2014 +0100

    h264parse: Set framerate even for interlaced videos
    
    Co-Authored by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
    
    https://bugzilla.gnome.org/show_bug.cgi?id=726752