After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726683 - make check/dist broken
make check/dist broken
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-19 08:17 UTC by Marek Chalupa
Modified: 2014-03-19 21:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remove removed files from EXTRA_DIST (670 bytes, patch)
2014-03-19 08:17 UTC, Marek Chalupa 		needs-work Details | Review
update POTFILES.in (815 bytes, patch)
2014-03-19 08:25 UTC, Marek Chalupa 		committed Details | Review

Description Marek Chalupa 2014-03-19 08:17:51 UTC 
Created attachment 272362 [details] [review]
remove removed files from EXTRA_DIST

Hi,

After update, running 'make check' results in:

Making check in po
make[1]: Entering directory `/home/marek/wayland/mutter/po'
make[1]: *** No rule to make target `../src/core/session.c', needed by `mutter-wayland.pot'.  Stop.
make[1]: Leaving directory `/home/marek/wayland/mutter/po'
make: *** [check-recursive] Error 1

https://git.gnome.org/browse/mutter/commit/?h=wayland&id=5fa5ace5e6023932399de1c7ec471f09c870cf7b

and running 'make dist':

make  dist-xz am__post_remove_distdir='@:'
make[1]: Entering directory `/home/marek/wayland/sandbox/mutter'
make[1]: *** No rule to make target `HACKING', needed by `distdir'.  Stop.
make[1]: Leaving directory `/home/marek/wayland/sandbox/mutter'
make: *** [dist] Error 2

https://git.gnome.org/browse/mutter/commit/?h=wayland&id=ff635bad3b72c70120a9bf4f78e8bdfb71fe6f0b

Verified on branch-new clone from git for the case I had some 'dirty' files in tree. Attached patch for the later one

Regards,
Marek Chalupa
Comment 1 Marek Chalupa 2014-03-19 08:25:14 UTC 
Created attachment 272364 [details] [review]
update POTFILES.in

fix for make check
Comment 2 Florian Müllner 2014-03-19 21:13:13 UTC 
Attachment 272364 [details] pushed as 27c018a - update POTFILES.in

Thanks! I'll push a slightly differently version of the first patch that I had already written when I remembered this bug go by (which doesn't split EXTRA_DIST between Makefile.am and doc/Makefile.am)